check status of external storage before file write/update

[templateK]

check status of external storage before file write/update

[AndyScherzinger]

This should imho be implemented with an equals since you are comparing Strings and to make it null safe I would suggest:

return Environment.MEDIA_MOUNTED.equals(Environment.getExternalStorageState());

[AndyScherzinger]

Hi @templateK
Thanks for your PR. Can you give some more details on the reason for the PR as in what is the impact of it. I looked through the code changes and found just one minor issue with a String comparison.

In case this is your first PR to any ownCloud repo, please fill out the contributor agreement, see https://owncloud.org/contribute/agreement/ , sign it and send it to @karlitschek and probably to @masensio
The agreement is a precondition in order to contribute code to the owncloud repos.

[templateK]

In file writing functions at FileDataStorageManager class,
(saveFile, saveFolder, moveLocalFile, copyLocalFile, updateSharedFiles)
they only checks existence of file on external storage.

Android external storage has many state for example, not-mounted, read-only etc.

So, I added condition that checks writable status of external storage to these functions.

[templateK]

I didn't noticed that there's contributor agreement. Sorry, that for my bad.
I have decided that I won't contribute to this project. Feel free to close this PR.

[tobiasKaminsky]

AFAIR you can also say that your code is under a special license, if you do not want to sign anything...

[ghost]

User of the commit is unknown - cannot determine CLA

[jesmrec]

closing... not scheduled