Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media player: Movie stop when turning device #1370

Closed
wants to merge 4 commits into from

Conversation

rishabh7m
Copy link
Contributor

Fix for bug #788

bug_906_fix_1

Revert "bug_906_fix_1"

This reverts commit 4e23ce3.

Revert "bug_906_fix_1"

This reverts commit 4e23ce3.

revert_906_fix_1

bug_906_fix_log

bug_906_log_fix

bug_906_log_1
This reverts commit 033e297.
@przybylski
Copy link
Member

This is not a correct way to handle this. Fixing this requires more sophisticated solution deep inside FileActivity

@LukeOwlclaw LukeOwlclaw mentioned this pull request Mar 18, 2016
@davivel
Copy link
Contributor

davivel commented Apr 26, 2016

As @przybylski , this is not the way. Including android:configChanges in AndroidManifest.xml is not enough to handle correctly configuration changes, and will have a lot of side effects leading to wrong behaviours in rotations.

What you try to do needs overriding also the method onConfigurationChanged(...) in the affected activities (see http://developer.android.com/intl/es/guide/topics/resources/runtime-changes.html).

Even in that case, that could not be the best strategy for our app, since there is already a lot of code in place to handle state in rotations taking into account that android:configChanges is not included.

Sorry, but this can't go in.

@davivel davivel closed this Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants