Resized images #1044
Resized images #1044
Conversation
|
When the reduced image is shown we could add a FAB to download the original file. |
|
@davivel Can we schedule this for the next milestone or the one after that? |
|
This would be huge and speed up the thumbnail loading significantly I can assume, in addition to the saved traffic! |
|
For now this PR depends on galleryplus for OC < 8.2 and gallery for OC >= 8.2. |
|
@tobiasKaminsky As soon as #1100 is merged to master I can add a FAB here, in case this is fine with @jancborchardt :) Besides that I will have to wait for OC 8.2 (Web Updater) |
|
@tobiasKaminsky I am not 100% sure if we are talking about the same thing, but I guess You know better as You are more involved in this thread. My original idea mentioned in #1278 was to show enlarged thumbnail and a spinning wheel instead of just a spinning wheel and a black background as for now while the larger preview is being downloaded / generated by the server (when we just look through pictures in fullscreen)
|
|
@rperez can we have this in the milestone after the current one? |
|
@tobiasKaminsky some doubts
|
|
@jancborchardt what do you think about including this on the product? By default not downloading the full resolution image? |
|
@tobiasKaminsky I’ve been using this in practice for quite some time in the Beta app. And I have to say it’s a bit unexpected. It’s great that the bigger thumbnail immediately shows so I can just view it. But as soon as the file is opened, it should download in the background. That’s somehow just expected. Right now every time I zoom into a picture, I have to wait additionally for it to be downloaded. But opening a picture is a desire to view it, hence ownCloud should directly download it. |
|
Currently I am using the owncloud as a giant photo album and it happens quite often that I show 50-100 pictures while I am not in WLAN. With this PR the transferred data is not 7MB per image but ~100Kb and therefore saves really really much traffic, which is expensive in germany ;) I remember that we talked about this quite some time ago and you proposed that the image could be auto-downloaded while zooming in at a certain level. |
Downloading is working just the way it is now.
OC < 8.2: galleryplus |
|
@tobiasKaminsky right, then let’s see what we can do to enhance this behavior. Download on zooming in is definitely good, but I feel this might not be enough. I would say the download should happen at already the tiniest amount of zoom, not only at a certain level. Is that ok? And maybe let’s also do it when a picture was viewed longer than x seconds, say 3? |
|
I am not so sure @jancborchardt if automatic downloading intermediately after starting a zoom is a good idea and I certainly disagree that starting a download after viewing the image for 3 secs automatically is a way to go. I have been using both beta and and a legacy app for a long time, and I love the behavior of beta concerning the images, as it allows me to comfortably view images and to save valuable space on my mobile device. Mobile data consumption and using limited space are the two main concerns I have on my mobile device, and I don't think it would be good to download some files automatically. The original photos are usually much larger then the previews and they would be hidden in a directory tree and it would make cleaning up those unintentionally downloaded original photos to free space unnecessarily time consuming and hideous. Most of the times viewing the previews of photos in full screen is sufficient (even on a tablet), and that is why I do not think that starting the download automatically after viewing the image for 3 ses would be a good idea, and many times I did a small zoom, but not always I wanted to download the original photo. But I do understand that it should be clear for the viewer that he is seeing a preview and not a poor quality original. What about showing a clickable text: "Do you want to download the original full size photo?" (obviously not as long, I wrote is so long to explain clearly the idea) when zooming starts? Is it technically doable? What do you think about this? |
|
There is something like that: https://github.com/JohnPersano/SuperToasts This could say "download full image: yes / no", and will be shown after zooming in with e.g. 2x .
I strongly disagree on downloading anything automatically. @jancborchardt I know that you do not like new settings, but is this something worth to put in? |
|
As an alternative to a "SuperToast" you could now also just make use of the Snackbar, like we now use it for hinting the user for granting the permission, see screenshot: #1343 (comment) |
|
Snackbar seems much better as it is not another lib! |
|
@jancborchardt is the one here |
Fix build gradle to generate release unsigned apk
Fix crash when adding a saml account
#296: Add documents provider
|
This is not active any more, #1599 is the place to go -> closing. |
Every image is loaded in a reduced version. The width and height is determinated by the screen.
If the user wants to have the real file, he has to long-click and select download.
The benefit is a very small, but yet usable preview of the image.
It can be used to send via whatsapp, or as a file to another app (like k9) with the correct filename.
Remaining problem:
owncloud/core#16250