Fix unknown error #1395
Closed
Fix unknown error #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mServerStatusView.setCompoundDrawablesWithIntrinsicBounds(mServerStatusIcon, 0, 0, 0); | ||
| mServerStatusView.setVisibility(View.VISIBLE); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| private void setStatusUrl(){ | ||
| String text = getString(R.string.auth_unknown_error_title) + "<br/>" + mHostUrlInput.getText().toString().trim() + "/status.php"; |
There was a problem hiding this comment.
I think that you should use formatted string:
String text = getString(R.string.auth_unknown_error_title, mHostUrlInput.getText().toString().trim() + "/status.php");and change auth_unknown_error_title string accordingly
|
+1 |
Closed
|
@davivel Can we merge this? |
|
Sorry, but as I explained in #1394 (comment) , this is bad UX. In #878 the request is showing the error message of status.php. Let's do that, not something halfway. 👎 |
|
Not planned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1394