-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unknown error #1395
Fix unknown error #1395
Conversation
mServerStatusView.setCompoundDrawablesWithIntrinsicBounds(mServerStatusIcon, 0, 0, 0); | ||
mServerStatusView.setVisibility(View.VISIBLE); | ||
} | ||
|
||
} | ||
|
||
private void setStatusUrl(){ | ||
String text = getString(R.string.auth_unknown_error_title) + "<br/>" + mHostUrlInput.getText().toString().trim() + "/status.php"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you should use formatted string:
String text = getString(R.string.auth_unknown_error_title, mHostUrlInput.getText().toString().trim() + "/status.php");
and change auth_unknown_error_title string accordingly
+1 |
@davivel Can we merge this? |
Sorry, but as I explained in #1394 (comment) , this is bad UX. In #878 the request is showing the error message of status.php. Let's do that, not something halfway. 👎 |
Not planned |
ref: #1394