Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple files upload from Google Photos application not working #1373

Closed
wants to merge 4 commits into from
Closed

Multiple files upload from Google Photos application not working #1373

wants to merge 4 commits into from

Conversation

rishabh7m
Copy link
Contributor

Fix for #1358

@rishabh7m
bug_906_fix
033e297 
bug_906_fix_1

Revert "bug_906_fix_1"

This reverts commit 4e23ce3.

Revert "bug_906_fix_1"

This reverts commit 4e23ce3.

revert_906_fix_1

bug_906_fix_log

bug_906_log_fix

bug_906_log_1
@rishabh7m
Merge branch 'master' of github.com:owncloud/android into bug_1358
64af288
@rishabh7m
patch_1_1358
3f85908
@rishabh7m
Revert "bug_906_fix"
7073eae 
This reverts commit 033e297.
@tobiasKaminsky
Copy link
Contributor

//getClipData is only supported on api level 16+, Jelly Bean
is said in comment.
@davivel which is our minimum required api?

Besides that: There is already a for-loop in the lines above (619ff which can be used, if the api level is not the problem...?)

@rishabh7m
Copy link
Contributor Author

I think data.getData() will not be null if we select content from other apps. If we cancel the selection then resultCode will not be RESULT_OK. I have tested by not selecting anything, one selection and multiple selections from the other app.

@LukeOwlclaw LukeOwlclaw mentioned this pull request Mar 18, 2016
Closed
@davivel
Copy link
Contributor

davivel commented Apr 26, 2016

@rishabh7m , what Android version has the device you are using to test? As @tobiasKaminsky said, multiple selection is not possible through this workflow for Android lower than 4.1.

@malkomich malkomich mentioned this pull request May 3, 2016
Closed
@jesmrec
Copy link
Collaborator

jesmrec commented Jun 26, 2019

Fixed in 2.11 with the native implementation

@jesmrec jesmrec closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh7m @tobiasKaminsky @davivel @jesmrec