Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fast scroll for all lists. Fixes #565 #1036

Closed
wants to merge 1 commit into from
Closed

Enable fast scroll for all lists. Fixes #565 #1036

wants to merge 1 commit into from

Conversation

jab416171
Copy link
Member

No description provided.

@tobiasKaminsky
Copy link
Contributor

This does not work for me:
06-28 10:19:11.218 24992-24992/com.owncloud.android E/AndroidRuntime﹕ FATAL EXCEPTION: main
java.lang.ClassCastException: third_parties.in.srain.cube.GridViewWithHeaderAndFooter$HeaderViewGridAdapter cannot be cast to android.widget.BaseAdapter
at android.widget.FastScroller.getSectionsFromIndexer(FastScroller.java:512)
at android.widget.FastScroller.getThumbPositionForListPosition(FastScroller.java:633)
at android.widget.FastScroller.onScroll(FastScroller.java:458)
at android.widget.AbsListView.invokeOnItemScrollListener(AbsListView.java:1275)
at android.widget.GridView.layoutChildren(GridView.java:1283)
at android.widget.AbsListView.onLayout(AbsListView.java:1865)
at android.view.View.layout(View.java:11278)
at android.view.ViewGroup.layout(ViewGroup.java:4224)
at android.support.v4.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:324)
at android.view.View.layout(View.java:11278)
at android.view.ViewGroup.layout(ViewGroup.java:4224)
at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
at android.view.View.layout(View.java:11278)
at android.view.ViewGroup.layout(ViewGroup.java:4224)
at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
at android.view.View.layout(View.java:11278)
at android.view.ViewGroup.layout(ViewGroup.java:4224)
at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
at android.view.View.layout(View.java:11278)
at android.view.ViewGroup.layout(ViewGroup.java:4224)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
at android.widget.LinearLayout.layoutHorizontal(LinearLayout.java:1617)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1401)

At least for GridView...

@tobiasKaminsky
Copy link
Contributor

For ListView it is working.
But there is currently a small graphic problem that shows first the old scroll bar and then the new fast scroll bar.

@jab416171
Copy link
Member Author

@tobiasKaminsky What device/android version?

@tobiasKaminsky
Copy link
Contributor

HTC Desire Z with 4.4.1

@davivel
Copy link
Contributor

davivel commented Apr 14, 2016

Hi, @jab416171 .

Sorry, but this will not work with grid view because we are using the extension GridViewWithHeaderAndFooter, and its subordinate HeaderViewGridAdapter is not extending the class BaseAdapter as the fast scroller expects. We could try to change that, but that might break GridViewWithHeaderAndFooter. See https://github.com/owncloud/android/blob/master/src/third_parties/in/srain/cube/GridViewWithHeaderAndFooter.java#L422 and the second line in the stack trace shown by @tobiasKaminsky .

About the list view, apparently is OK, but it's not working at all in Nexus 5 with Android 6; I don't know if it's a problem with Material Design, Android version, or just that I don't have enough files in my folders.

By the way, is there a minimum list size to show the fast scroller?

@jab416171 , would you have time and will to resume the work here and fix the problems? Thanks in advance.

@tobiasKaminsky
Copy link
Contributor

For gridView I made a PR that allows to zoom in/out to have more/less columns visible.
Maybe this is enough for gridView and ListView can support the fast scroll?

@tobiasKaminsky
Copy link
Contributor

#1402

@jesmrec
Copy link
Collaborator

jesmrec commented Jun 26, 2019

outdated. If you think it's needed, feel free to reopen.

@jesmrec jesmrec closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants