Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subheaders of share view #1413

Closed
jancborchardt opened this issue Jan 8, 2016 · 6 comments
Closed

Subheaders of share view #1413

jancborchardt opened this issue Jan 8, 2016 · 6 comments
Assignees
Milestone

Comments

@jancborchardt
Copy link
Member

Currently the share popup has these dark blue header boxes. This is a tad jarring and should instead be done by whitespace and proper header text (darkblue text color). Just like in the settings.

(Also, the Share text at the very top of the box should be correctly left aligned with the rest of the text.)

@AndyScherzinger
Copy link
Contributor

I can work on this and also work on the search pop up for user and groups regarding margins and padding.

@jancborchardt
Copy link
Member Author

Awesome! :)

@AndyScherzinger
Copy link
Contributor

Just FYI development has been started on a new branch https://github.com/owncloud/android/tree/1413_share_view_enhancement

@AndyScherzinger
Copy link
Contributor

Thing I didn't change is the title (!) due to that being Material Standard, thus the content is a bit more to the left. In case we need this I would move the title to the content and not use the title at all.

@AndyScherzinger
Copy link
Contributor

pinging @jancborchardt for feedback on #1416 - so I can push it to beta :)

@davivel
Copy link
Contributor

davivel commented Mar 30, 2016

This was merged into master, and will be released in version 1.9.2

@davivel davivel closed this as completed Mar 30, 2016
@davivel davivel added this to the 1.9.2-current milestone Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants