#1413 share view enhancement - REDONE

[AndyScherzinger]

For details and discussion please see #1413 and original PR #1416

[mention-bot]

By analyzing the blame information on this pull request, we identified @davivel and @malkomich to be potential reviewers

[AndyScherzinger]

Screenshots...

[AndyScherzinger]

@jancborchardt one thing, the user list with 1.9.2 will have three kinds of item types, users, groups and federated shares. For federated I use the "user" icon at the moment, so we are in need for an icon 😄

[jancborchardt]

@AndyScherzinger it’s fine to use the same icon for federated shares, since we want to make the difference as little as possible to have a similarly seamless UX. In the list display, the username should be displayed like tobias@… (with the server really being dotted out, like in the web app).

[AndyScherzinger]

Do you have a screenshot for the @... for user and group to see the difference?

[AndyScherzinger]

@davivel is there a test account somewhere that I could use to the the federated shares in action and do the possible UI changes?

[davivel]

@AndyScherzinger , thanks a lot for redoing this one.

is there a test account somewhere that I could use to the the federated shares

That's going to be difficult for the short term. And we are interested in this for a very, very, very short term.

In the list display, the username should be displayed like tobias@… (with the server really being dotted out, like in the web app).

@jancborchardt , we made the list following the web UI, but I can't remember any .... What OC server includes that?

[AndyScherzinger]

@davivel you are welcome! No worries, I just wanted to see the user/group/federated display in the web app to better understand Jan's requirement here :)

[davivel]

Should be match_parent, fill_parent is old wording, long time deprecated (though harmless)

[AndyScherzinger]

fixed along with some alignment optimizations 968373a

[davivel]

I can upload some screenshots :)

[davivel]

Captures of web UI while sharing and after shared. I guess the ... talked about are those at the end of user when there is not space enough in a single line (see second picture).

[davivel]

Code is 👍

@AndyScherzinger , this is your chance to make a very easy rebase ;-)

git pull
git checkout 1413_share_view_enhancement_redo
git rebase master

[davivel]

cc @jesmrec , ready to test.

[AndyScherzinger]

😞

git rebase master ends up with:

fatal: Needed a single revision
invalid upstream master

[davivel]

Do you have local copy of master?

Try git checkout master, then back to git checkout 1413_share_view_enhancement_redo

[AndyScherzinger]

Hmmmm, I don't get it... Tried what you said, see commit history, again all commits doubled...

We should stop trying to make rebases work for now imho, with the amount of commits this is just to risky. If everything goes according to plan we might be able to teach me this stuff at the next conference... 😞

[AndyScherzinger]

@jancborchardt looking at the screenshots this might be a really tricky one since we don't have that much space on a cellphone, right?

[AndyScherzinger]

Else we might be able to do two lines and add that to a second line - ?

[davivel]

Two lines not, please...

Let me see how it's now, I'll push a screenshot with a federated share.

[AndyScherzinger]

I'm fine with it the way it is, question is, if we pack in the server address + port it'll be very packed. That is just my concern here.

[davivel]

Hmmmm, I don't get it... Tried what you said, see commit history, again all commits doubled...

Don't worry, I rebased. This was not so tricky, since there was no conflict.

@jancborchardt , screenshot of federated share:

Ellipsis is done in the middle, a common practice in our mobile apps, if I recall correctly. Is it OK, or should we ellipsize in the end ?

[AndyScherzinger]

Looks good to me 👍
Personally I would stick with the ellipsis in the middle like @davivel said this common practice in the mobile app and ellipsizing at the end but still having the port definition makes things a bit complicated just for the display of the more or less irrelevant information from an end user's perspective (port number).

[AndyScherzinger]

@carlaschroder just in case this is relevant for documentation, please see above the latest screenshots of the share dialog(s) for the upcoming release 1.9.2 😃

[javiergonzper]

QA approved 👍

[davivel]

Then... in!

[AndyScherzinger]

AWESOME! 🎉

[jancborchardt]

Nice, very cool! :)