updates for 2.0 release #1627
updates for 2.0 release #1627
Conversation
|
By analyzing the blame information on this pull request, we identified @danimo to be a potential reviewer |
|
Hi @carlaschroder the issue you are refering to is #1493
|
|
@carlaschroder , the uploads view is not show automatically. You need to open the side drawer sliding from the left border of the list of files, or clicking on the burger menu. Then click on "Uploads" |
|
@carlaschroder , for next release we'll ping you before doing the release, I promise; we need to take the documentation more seriously. cc @rperezb |
|
@davivel we take documentation very seriously 👼 I have open several issues on the doc repo |
|
@carlaschroder on your screenshot user_manual/images/android-5.png you may notice that there is a new section: Uploads this is it! |
@rperezb has kept me well-informed. That is why the updates are out now instead of weeks from now :) |
|
dangit, this out of sync with the master branch already. Stop doing that :) |
|
ok then, a new commit describing the update status indicator. |
| shortcut to your files, the **Uploads** button, and the **Settings** button. | ||
|
|
||
| The Uploads page displays the status of files currently uploading, a list of | ||
| your recently-uploaded files, and a Retry option for any failed uploads. |
There was a problem hiding this comment.
Plus I'd add that it's possible to fix failed uploads, the meaning of this is that:
- if the credentials have been changed, it's shown credentials error and when you click on the failed uploads the login view is open for you to update the credentials
- Privileges error, in case you select to upload files to a folders without privileges. In this case you may select a different folder..
....
More info on the test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.0.0/1493-reliable_uploads_actions_uploads_view.md
There was a problem hiding this comment.
Mmmm, I could be wrong, but I don't remember we implemented the recovery option for "Privileges error".
There was a problem hiding this comment.
Could you find out? It shouldn't take weeks to approve documentation :)
There was a problem hiding this comment.
I can confirm, Carla. An upload to a folder where the user cannot write ends with a failed upload with "Permission error". If the users taps on it in the uploads view, the upload is directly retried, finishing again in "Permission error". Unless something is done outside the app to grant the permission, the upload will always fail
There was a problem hiding this comment.
Awesome sauce, thanks. Corrections committed.
|
See how you like it now :) |
|
Is this good to merge yet? It's not getting any fresher sitting here :) |
| # The full version, including alpha/beta/rc tags. | ||
| release = '1.9.1' | ||
| release = '2.0' |
There was a problem hiding this comment.
For consistency throughout the project format of version should always be three-fold x.y.z, so 2.0.0 here.
|
sigh. I'm done-- you nice people fix it and merge it. |
|
@carlaschroder , sorry for the pain :( I will give it a final look tomorrow and go all the way 'til merging. Promised. |
|
Thanks @davivel , and thanks @LukeOwncloud. |
AndyScherzinger
force-pushed
the
2-0-manual
branch
from
93a3bdb to
063921b
Compare
|
@davivel Review comments resolved and branch rebased to master. Feel free to check and hit the merge button :) |
|
I feel the power! Thanks everyone. |
|
👍 Thanks @AndyScherzinger |
Allrighty friends, this release looks gorgeous.
I did not see the upload views shown in #1551 I tried uploading multiple files, which works fine, but the uploads indicator is just a little message on the top left.
@rperezb @davivel @AndyScherzinger