OFN without spree_backend 🎉

[luisramos0]

What? Why?

What a wonderful PR! It makes you dream of future PRs "OFN without Spree" or even "OFN on rails 6". We can do it 💪

Closes #4595 and #4050.

We remove spree_backend and make final adaptations to our code to make it possible.

Dear reviewer: I think you can review just the final changes without going through the commit history, I think it's readable :-)

What should we test?

The bad news about this PR... we need to test every single corner of the backoffice...

I'd say we need to go through all the test steps of most PRs in both epics: #4595 and #4050.

I have gone through them all and I made a summary here as a task list (please follow the test steps in each of these PRs):

• Bring spree_backend base controller to OFN  #4512 - important basic checks
• Remove unused js dependencies (jquery-migrate-1.0.0 and timeago) and bring some legacy browsers support dependencies from spree_backend #4607 - browser stack test
• Bring basic CSS rules from spree backend #4620 - manual visual comparison with prod (also verify the font is the same, Bring fontawesome font and associated css from spree_backend #4628)
• Bring some basic js functions and dependencies from spree_backend #4614 - various UI verifications (for example, date pickers, pagination elements, tables, filters, adding and sorting columns in tables) - (product properties is covered in the PR below as well)
• Move properties and product properties from spree_backend to OFN  #4449 - product_properties and properties
• Bring spree_backend orders controller to OFN  #4513, Bring some JS and CSS code from spree_backend related to orders admin #4616, Move Images from spree_backend to OFN #4372 and 4508 - different tests on products and orders pages
• Bring spree_backend adjustments controller to OFN #4515 - order adjustments
• Bring spree_backend payments controller to OFN #4509 - order payments
• Move return authorizations from spree_backend to OFN #4450 - order return_authorizations
• Bring remaining variants autocomplete (and related) JS code from spree_backend #4613 and Bring spree_backend search controller to OFN #4511 - autocomplete and search tests
• Bring base helper from spree_backend #4588 - this is mostly covered in other tests above
  Configuration:
• Bring some js and css code from spree_backend needs in the general configurations #4617, Move zones, countries and states from spree_backend to OFN #4290 and Move general_settings, mail_methods and image_settings from spree_backend to OFN #4289 - various changes in the general settings
• Move tax_rates, tax categories and tax settings from spree_backend to OFN #4292 - tax_categories, tax_rates and tax_settings
• Move shipping_methods and shipping categories from spree_backend to OFN #4269, Move Payment methods from spree_backend to OFN #4371 and Bring spree_backend calculator fields partial to OFN #4585 - shipping_methods, payment_methods and shipping_categories
• Bring js code to make taxonomies admin work without spree_backend #4611 and Move taxons and taxonomies from spree_backend to OFN  #4291 - taxonomies and taxons setup and usage
  Other stuff:
• Bring spree_backend overview controller to OFN #4514 - verify the overview dashboard
• Bring spree_backend reports controller to OFN #4507 - sanity check reports
• Bring spree_backend resource controller to OFN #4510 - some other tests (enterprise, subs and bulk variants) that should be done now as well

Release notes

Changelog Category: Changed
OFN is now independent of spree_backend 🎉

[mkllnk]

Wow! 🚀

It all makes sense. No logic change. The real burden is really on testers. Now I wish we had automated visual testing.

Just as an idea. Could we override visit in all feature specs to save a screenshot. Run it on master then run it on the pr and do a diff of all the images? Maybe too much work...

[mkllnk]

This looks promising: https://github.com/gabrielrotbart/gatling

[luisramos0]

Test Ready....

[RachL]

@luisramos0 this is what I see when I try to add a new image through the product edit page. From build page, everything is ok

If there is already an image, clicking the new image button, just makes the button disappear 🙈

This is not happening in production.

Also on the test:

Add a state to a country and then change to another country and try to add a state to that new country.

I didn't see how to change a country's state? I don't think it is possible through the UI? Not that you can have the same state to one country:

Full testing notes:

https://docs.google.com/document/d/1WtsRAmGHKRbBLLDTRH4cj5My4-C0AfTM5jTp9EEagVY/edit#

After your answers I will still have to run a couple of sanity test and we should be good to go.

[luisramos0]

hello @RachL thanks a lot for testing all this!!!!

Re iamges, it was a little bug, I fixed it and added a spec to verify this "new image" page loads correctly. We are not yet testing the image upload itself though.
You can restage and retest. Should be good now.

EDITED: Re states, when I write "and then change to another country" I mean to change the page to another country on the top selector so that you can edit the states of another country.

[luisramos0]

I redeployed and tested in FR staging, the images issue is now fixed 👍

[RachL]

Re state: all good then!!

Re images: all good as well. I noticed thanks to this that we allow a product to have several images, but it does not appear in the shopfront. This is like this in production as well, so all good here.

Sanity check : all good.

I believe we are ready to go!!!

[luisramos0]

great!