Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move taxons and taxonomies from spree_backend to OFN #4291

Merged

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Sep 20, 2019

What? Why?

Part of #4050

This moves all things related to taxonomies and taxons from spree_backend to OFN. No change in functionality.

What should we test?

The pages must work correctly as before.
Taxonomies: create taxonomy, sort taxonomies. Edit taxonomy: (use right click) add, rename, remove and edit Taxons.
Existing issues:

Release notes

Changelog Category: Changed

Imported views from spree_backend to make OFN more independent of Spree.

@Matt-Yorkley
Copy link
Contributor

There's quite a few Codeclimate issues. Do you want to handle them separately?

@luisramos0
Copy link
Contributor Author

this is spree code, these are the not easy ones (complexity, etc). I dont want to fix all of them, a lot of work...

@luisramos0
Copy link
Contributor Author

moving to test ready.

@RachL RachL assigned RachL and unassigned RachL Oct 2, 2019
@RachL
Copy link
Contributor

RachL commented Oct 2, 2019

@luisramos0 code climate is complaining. Can I still test it?

@luisramos0
Copy link
Contributor Author

yes @RachL I dont think we need to fix all issues in the spree code.

@RachL RachL self-assigned this Oct 2, 2019
@RachL RachL added pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Oct 2, 2019
@RachL RachL removed their assignment Oct 2, 2019
@RachL RachL added the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 2, 2019
@RachL RachL self-assigned this Oct 2, 2019
@RachL
Copy link
Contributor

RachL commented Oct 2, 2019

@luisramos0 I wonder : how can I actually create a taxonomy? I would need to drag it above "products" which is our main taxonomy, right?

@luisramos0
Copy link
Contributor Author

you use the button "new taxonomy"

@RachL
Copy link
Contributor

RachL commented Oct 2, 2019

@luisramos0 🤦‍♀️ I was looking at the edit taxonomy page, so sorry.

Taxonomies:CRUD is working. Sorting is working in the UI, but not in the product category list
Taxons : add and edit is working.

I believe we will need another issue for sorting taxonomies. But this is pre-existing so it is ready to go!

@RachL RachL removed the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 2, 2019
@luisramos0 luisramos0 merged commit e640816 into openfoodfoundation:master Oct 2, 2019
@luisramos0 luisramos0 deleted the spree_be_config_taxons branch October 2, 2019 20:13
@luisramos0
Copy link
Contributor Author

thank you!
there's an issue already for the sorting problem: #2944

@RachL
Copy link
Contributor

RachL commented Oct 3, 2019

@luisramos0 this issues covers the sorting within a taxonomy so the sorting of taxons. But I tested as well the sorting of taxonomies. And nothing happened on the categories dropdown when creating a product for example. But I guess for now sorting taxonomies is less prioritary.

@luisramos0
Copy link
Contributor Author

yeah, and is the order of taxonomies used anywhere now? I mean, the product categories are not taxonomies, they are taxons inside the Product Categories taxonomy.

@RachL
Copy link
Contributor

RachL commented Oct 3, 2019

🤕 yeah it's really weird. I guess users should not be able to select them as categories. But I remember there is already a discussion somewhere on discourse about that.

@luisramos0
Copy link
Contributor Author

I dont think I understand what is weird. We have a taxonomies system and we use one of the taxonomies as product categories. What's the confusion?

@sigmundpetersen
Copy link
Contributor

sigmundpetersen commented Oct 3, 2019

In 'New Product' you can choose the taxonomy as one of the categories, e.g. 'Products', 'Others'. I guess that's the weird thing you mention, no @RachL ? They're sorted alphabetically among the other taxons/categories

@luisramos0
Copy link
Contributor Author

ah, my mistake, all taxonomies and all taxons are shown on the product categories list. I think only taxons inside the Products taxonomy should be shown. But that's not the case now.

@luisramos0 luisramos0 mentioned this pull request Feb 6, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants