-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move taxons and taxonomies from spree_backend to OFN #4291
Move taxons and taxonomies from spree_backend to OFN #4291
Conversation
…can merge them with their decorator in a second step
…t are missing in ofn
There's quite a few Codeclimate issues. Do you want to handle them separately? |
this is spree code, these are the not easy ones (complexity, etc). I dont want to fix all of them, a lot of work... |
moving to test ready. |
@luisramos0 code climate is complaining. Can I still test it? |
yes @RachL I dont think we need to fix all issues in the spree code. |
@luisramos0 I wonder : how can I actually create a taxonomy? I would need to drag it above "products" which is our main taxonomy, right? |
you use the button "new taxonomy" |
@luisramos0 🤦♀️ I was looking at the edit taxonomy page, so sorry. Taxonomies:CRUD is working. Sorting is working in the UI, but not in the product category list I believe we will need another issue for sorting taxonomies. But this is pre-existing so it is ready to go! |
thank you! |
@luisramos0 this issues covers the sorting within a taxonomy so the sorting of taxons. But I tested as well the sorting of taxonomies. And nothing happened on the categories dropdown when creating a product for example. But I guess for now sorting taxonomies is less prioritary. |
yeah, and is the order of taxonomies used anywhere now? I mean, the product categories are not taxonomies, they are taxons inside the Product Categories taxonomy. |
🤕 yeah it's really weird. I guess users should not be able to select them as categories. But I remember there is already a discussion somewhere on discourse about that. |
I dont think I understand what is weird. We have a taxonomies system and we use one of the taxonomies as product categories. What's the confusion? |
In 'New Product' you can choose the taxonomy as one of the categories, e.g. 'Products', 'Others'. I guess that's the weird thing you mention, no @RachL ? They're sorted alphabetically among the other taxons/categories |
ah, my mistake, all taxonomies and all taxons are shown on the product categories list. I think only taxons inside the Products taxonomy should be shown. But that's not the case now. |
What? Why?
Part of #4050
This moves all things related to taxonomies and taxons from spree_backend to OFN. No change in functionality.
What should we test?
The pages must work correctly as before.
Taxonomies: create taxonomy, sort taxonomies. Edit taxonomy: (use right click) add, rename, remove and edit Taxons.
Existing issues:
Release notes
Changelog Category: Changed
Imported views from spree_backend to make OFN more independent of Spree.