Bring spree_backend base controller to OFN

[luisramos0]

What? Why?

Related to #4050

Here we bring spree/admin/base_controller to OFN and merge its decorator.

One of the reasons we are doing this, we bring some code we need but end up deleting a good part of it or related useless stuff (like the alerts in this case) leaving us with basically the same number of lines of code:

What should we test?

We remove a dead feature in spree (security alerts from spree itself). In general settings there was this checkbox, it's now gone:

This controller is the parent of all controllers in spree.
This is what I think we should validate:

• navigation - menus and submenus work (we can test a few of them)
• changing language works in both frontoffice and backoffice
• authorization - try to access a URL a manager is not allowed with a manager logged in, like going to admin/general_settings/edit with a user who is just a manager
• api key - make sure that a page like orders list or products list basic functions work (this requires an api key to be in place)
• flash_message_for - make sure you see the flash message when successfully updating an enterprise
• banner - make sure that if you have an enterprise with an OC but without payment methods you see a flash message on top of the menu mentioned that problem

Release notes

Changelog Category: Changed
Moved basic admin controller code to OFN to remove dependency from Spree.

[mkllnk]

Yay! Such a good cleanup.

There are two Code Climate complaints. I don't think you need to reduce the lines of code here because that's out of scope. But it would be nice to simply change URI.unescape to CGI.unescape. Otherwise we have to change that when upgrading. URI.unescape has been deprecated in Ruby 2.5.5.

[luisramos0]

Thanks Maikel, I changed to CGI.unescaped 👍

[luisramos0]

I removed a line of code I now realize is not needed. the helper method is never used in our code base.

[RachL]

navigation - menus and submenus work (we can test a few of them)

All good.

changing language works in both frontoffice and backoffice

All good.

authorization - try to access a URL a manager is not allowed with a manager logged in, like going to admin/general_settings/edit with a user who is just a manager

All good

api key - make sure that a page like orders list or products list basic functions work (this requires an api key to be in place)

All good. Tested CRUD and bulk update.

flash_message_for - make sure you see the flash message when successfully updating an enterprise

All good.

banner - make sure that if you have an enterprise with an OC but without payment methods you see a flash message on top of the menu mentioned that problem

@luisramos0 to my knowledge this banner only show up as super admin. I tried to create an OC without payment methods and now the new layout tell me I cannot select my hub if I don't have a payment method. I guess you added a test for this? Which is I think the perfect way to go 👍

Anyway as this is impacting super admin only, I'm moving it to ready to go.

[luisramos0]

just to play on the safe side here, lets confirm we are on the same page.
Yes, the hubs cant be added to the OC without payment methods, that is good.
BUT for example if you remove the last payment method from a hub already in an OC, you should see the banner as a manager...
If you dont see this banner in this case, it could be a bug, and it could have been introduced by this PR.

[RachL]

@luisramos0 yes but I can't delete a payment method once it is in the OC... Or you mean a fresh OC with no orders yet?

[luisramos0]

I didnt say delete, I said "remove the last payment method from a hub". I should have said "remove the hub from the list of enterprises associated with the payment method" :-) do you see what I mean?

[RachL]

Ok yes sorry I missunderstood. This is working:

Moving to ready to go!

[luisramos0]

ah, nice, thanks @RachL