Bring js code to make taxonomies admin work without spree_backend #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
changed the title
78 tasks
Matt-Yorkley
approved these changes
Dec 27, 2019
mkllnk
approved these changes
Jan 8, 2020
luisramos0
force-pushed
the
taxonomies_js
branch
from
0262f1b to
0ea98fd
Compare
|
I rebased and tested deploying. All good. Ready for testing. |
luisramos0
force-pushed
the
taxonomies_js
branch
from
f71f033 to
908e553
Compare
|
ping @luisramos0 #conflicts |
…ery.alerts from spree_backend
luisramos0
force-pushed
the
taxonomies_js
branch
from
908e553 to
9a2ad16
Compare
|
rebased 👍 |
|
Tested creating a taxon and associating with a product. Ready to go :-) |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Continues to #4595
We need to bring jstree from spree_backend so that the taxonomies admin page works in the backoffice. We remove one usage of jConfirm to avoid having to bring jquery.alert as well.
We create a folder admin/spree where we will put the not angularized JS legacy code coming from spree_backend. It's not much code but I think it's better if we keep it isolated under admin/spree/.
What should we test?
The taxons admin page in the backoffice is working correctly, particularly setting up hierarchies and renaming and deleting elements.
Release notes
Changelog Category: Changed
Brought from spree_backend code to make taxons admin page work without spree code so that we make ofn independent of spree.