-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move shipping_methods and shipping categories from spree_backend to OFN #4269
Move shipping_methods and shipping categories from spree_backend to OFN #4269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gogogo!
55137c7
to
fc433ff
Compare
@lin-d-hop would this be worthy of an admin UX (or maybe it already is)? |
Hi :-) What was tested: Observed:
I didn't detect any further errors, from moving the code from spree_backend to OFN. |
well done Filipe! |
What? Why?
Part of #4050
This moves all things related to shipping methods and shipping categories from spree_backend to OFN.
What should we test?
The code was just moved around so a basic test should do.
Existing bug around User feedback on delete:
The flash message after pressing the delete button is still not showing. It was broken before, I tried fixing it now but didnt manage to. Still not showing.
If ship method is deleted successfully, no flash message to user.
If the ship method is referenced by an order, the ship method is not deleted and no flash message to user is shown. But the ship method will disappear from the list and reappear if user refreshes page 🙈
Release notes
Changelog Category: Changed
Imported views from spree_backend to make OFN more independent of Spree.