Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shipping_methods and shipping categories from spree_backend to OFN #4269

Merged
merged 4 commits into from
Oct 3, 2019

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Sep 17, 2019

What? Why?

Part of #4050

This moves all things related to shipping methods and shipping categories from spree_backend to OFN.

What should we test?

The code was just moved around so a basic test should do.

Existing bug around User feedback on delete:
The flash message after pressing the delete button is still not showing. It was broken before, I tried fixing it now but didnt manage to. Still not showing.
If ship method is deleted successfully, no flash message to user.
If the ship method is referenced by an order, the ship method is not deleted and no flash message to user is shown. But the ship method will disappear from the list and reappear if user refreshes page 🙈

Release notes

Changelog Category: Changed

Imported views from spree_backend to make OFN more independent of Spree.

@luisramos0 luisramos0 self-assigned this Sep 17, 2019
@luisramos0 luisramos0 changed the title Spree be config WIP Spree be config Sep 17, 2019
Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo!

@luisramos0 luisramos0 changed the title WIP Spree be config Move shipping_methods and shipping categories from spree_backend to OFN Sep 20, 2019
@luisramos0 luisramos0 removed the pr-wip label Sep 20, 2019
@daniellemoorhead
Copy link
Contributor

The flash message after pressing the delete button is still not showing. It was broken before, I tried fixing it now but didnt manage to. Still not showing.
If ship method is deleted successfully, no flash message to user.
If the ship method is referenced by an order, the ship method is not deleted and no flash message to user is shown. But the ship method will disappear from the list and reappear if user refreshes page 🙈

@lin-d-hop would this be worthy of an admin UX (or maybe it already is)?

@filipefurtad0
Copy link
Contributor

Hi :-)

What was tested:
Performed general test on Katuma as Administrator, creating user, adding/deleting, managing order cycles.
Created user, ordered a product.

Observed:
All worked fine. Verified the bugs you previously mentioned:

  • The flash message after pressing the delete button is still not showing.
  • If ship method is deleted successfully, no flash message to user.
  • If the ship method is referenced by an order, the ship method is not deleted and no flash message to user is shown. But the ship method will disappear from the list and reappear if user refreshes page

I didn't detect any further errors, from moving the code from spree_backend to OFN.
Moving to Ready to Go! 🎉

@luisramos0 luisramos0 merged commit c15660d into openfoodfoundation:master Oct 3, 2019
@luisramos0 luisramos0 deleted the spree_be_config branch October 3, 2019 12:45
@luisramos0
Copy link
Contributor Author

well done Filipe!

@luisramos0 luisramos0 mentioned this pull request Feb 6, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants