-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring some basic js functions and dependencies from spree_backend #4614
Bring some basic js functions and dependencies from spree_backend #4614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I look forward to the day we can 🔥 all of this code...
🙂
72b3fda
to
21a6354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but an additional spec is failing. That spec fails on my local machine as well. But on my local machine it also fails on master. 🤷♀️
d89707b
to
2c2a075
Compare
There was a problem with the assets compilation and now with the build. I'll get this ready for testing tomorrow. |
2c2a075
to
21c2ee9
Compare
This is deploying correctly now. Ready for testing. |
b7600bb
to
7fd439d
Compare
producer properties - tested editing, reordering, also checked on products. I think this is good to go. However while testing the page has become conflicted ping @luisramos0 Fingers crossed that I don't need to retest after these conflicts are fixed. |
… requires that are not used in ofn
…icator js and css
These events can only be added to OFN when spree_backend is removed otherwise the evetns will be registered twice
…ow because it is already called in spree_backend This can be reverted when spree_backend is removed
…endencies from spree_backend
7fd439d
to
0648f23
Compare
great, thanks a lot for testing. |
What? Why?
Continues #4595
In this PR we bring from spree_backend the following code:
What should we test?
We need to validate the following behaviors:
Release notes
Changelog Category: Changed
Bring some basic js functions from spree_backend to make OFN independent of Spree.