-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring spree_backend payments controller to OFN #4509
Bring spree_backend payments controller to OFN #4509
Conversation
990b823
to
c1840ce
Compare
1ffc055
to
5297795
Compare
Needs a rebase @luisramos0 |
5297795
to
d5e5582
Compare
Also needs a rebase |
…t with the OFN's decorator
…e only index, create, new and fire actions in this controller
d5e5582
to
766303b
Compare
👍 done |
@luisramos0 when I click on a payment method of an order, I get an error 500 and I don't see this in production. Could it be linked to this PR? Example link: https://staging.katuma.org/admin/orders/R064445101/payments/174 |
It was a bug in my migration of the code, I didn't see there was a show action. This link on the "payment method" column goes to a page that shows the payment... |
ready for testing in katuma. |
Great I think this is ready to go! I've tested creating, capturing and cancelling on all 3 payments methods. Also
This is working as well 🎉 |
What? Why?
Related to #4050
We bring payments_controller from spree_Backend and merge the decorator in OFN.
We fix some rubocop issues but leave abc size and method length on create and fire for later. These are reflected in the new todo_manual file.
What should we test?
We need to verify the page to capture payments in the order.
Create payment, capture payment, cancel payment.
We should test these things above with several order states as well as several payment methods.
There's this edge case where we delete the payment method and the list of payments of a past order with that payment method still shows the name of that deleted payment method correctly. I wonder if this is working in the current version. I havent tested this.
Release notes
Changelog Category: Changed
Brought the backoffice page that captures payments from spree to make OFN independent of Spree.