-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring some js and css code from spree_backend needs in the general configurations #4617
Conversation
230a615
to
e40df47
Compare
rebased and tested deployment process. all good, ready for testing. |
Image settings. The form appears to work. When I click new the form offers me 2 new options and I have to remove one to save. States - adding states to different countries persists as expected Calculators - warning shows correctly in Shipping and Payment methods Zones - Works correctly but when I go to add a new zone I am shown 2 additional zones fields instead of one. Same problem as above. As this double up of fields is happening in multiple places I fear that we might find this popping up all over which will create an additional support demand for new instances as we have to explain that to save you must delete on of the additional fields. Not sure if this will also flow through to user facing areas. So despite it being small and easily worked around I suggest we just fix this here and now. Back to In Dev. |
ah, the code is duplicated between spree and OFN now, that's why we see two entries... "we might find this popping up all over " - we are only changing these pages, nothing else. There's no risk of seeing this in other places. Agree, we shouldnt put this in produiction. |
Closing, this is going in as part of #4621 |
What? Why?
Continues #4595
What should we test?
Image settings:
States:
Calculator Fields:
Zones:
Release notes
Changelog Category: Changed
Bring code from spree_backend related to general configurations so that we can make OFN independent of Spree.