-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring spree_backend orders controller to OFN #4513
Bring spree_backend orders controller to OFN #4513
Conversation
cffffed
to
66539a0
Compare
@@ -0,0 +1,72 @@ | |||
<% if use_billing %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #4584 to convert this to haml at a later stage.
dba1bbe
to
d63090c
Compare
d63090c
to
2ee95fd
Compare
2ee95fd
to
8656c77
Compare
rebase to resolve simple conflict. |
Workflow doing ok as usual.
All good
All good
All good
Yes!
This is ready to go! |
… merge it with the OFN's decorator
…with the OFN's decorator
…manual todo accordingly
…decorator Remove useless todo comment
8656c77
to
d32e106
Compare
rebased to resolve minor conflicts |
What? Why?
Relates to #4050
Here we bring orders and customer details controllers from spree and merge them with the existing decorators.
Fixed some rubop issues and updated rubocop manual todo with remaining rubocop issues like abc size and method length.
What should we test?
We need to test the full admin orders workflow. Mainly the workflow, not the details.
Listing orders - here particularly the actions of shipping and capturing payments of an order from the orders list page.
Create/edit order - make sure we can add line items and add customer details as usual.
We should also validate that the actions work correctly like printing invoice and cancelling/resuming the order.
We should verify, on the edit order page, the order state and total value as well as the shipment and payment state appear correctly on the right side menu: the shipment/payment state only appear if the order is complete.
On the customer details the address form fields were moved from spree to ofn here so we should check it renders correctly all the fields.
Release notes
Changelog Category: Changed
Brought from spree_backend code related to editing an order in the backoffice so we can make OFN independent of Spree.