Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring spree_backend orders controller to OFN #4513

Merged
merged 12 commits into from
Feb 4, 2020

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Nov 27, 2019

What? Why?

Relates to #4050

Here we bring orders and customer details controllers from spree and merge them with the existing decorators.

Fixed some rubop issues and updated rubocop manual todo with remaining rubocop issues like abc size and method length.

What should we test?

We need to test the full admin orders workflow. Mainly the workflow, not the details.
Listing orders - here particularly the actions of shipping and capturing payments of an order from the orders list page.
Create/edit order - make sure we can add line items and add customer details as usual.
We should also validate that the actions work correctly like printing invoice and cancelling/resuming the order.
We should verify, on the edit order page, the order state and total value as well as the shipment and payment state appear correctly on the right side menu: the shipment/payment state only appear if the order is complete.
On the customer details the address form fields were moved from spree to ofn here so we should check it renders correctly all the fields.

Release notes

Changelog Category: Changed
Brought from spree_backend code related to editing an order in the backoffice so we can make OFN independent of Spree.

@luisramos0 luisramos0 self-assigned this Nov 27, 2019
@luisramos0 luisramos0 force-pushed the backend_ctrl_orders branch 2 times, most recently from cffffed to 66539a0 Compare December 14, 2019 15:15
@luisramos0 luisramos0 removed the pr-wip label Dec 14, 2019
@luisramos0 luisramos0 changed the title WIP Bring spree_backend orders controller to OFN Bring spree_backend orders controller to OFN Dec 14, 2019
@@ -0,0 +1,72 @@
<% if use_billing %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #4584 to convert this to haml at a later stage.

@luisramos0
Copy link
Contributor Author

rebase to resolve simple conflict.

@RachL RachL self-assigned this Feb 4, 2020
@RachL
Copy link
Contributor

RachL commented Feb 4, 2020

We need to test the full admin orders workflow. Mainly the workflow, not the details.

Workflow doing ok as usual.

Listing orders - here particularly the actions of shipping and capturing payments of an order from the orders list page.

All good

Create/edit order - make sure we can add line items and add customer details as usual.

All good

We should also validate that the actions work correctly like printing invoice and cancelling/resuming the order.

All good

We should verify, on the edit order page, the order state and total value as well as the shipment and payment state appear correctly on the right side menu: the shipment/payment state only appear if the order is complete.

Yes!

On the customer details the address form fields were moved from spree to ofn here so we should check it renders correctly all the fields.

This is ready to go!

@RachL RachL removed the pr-staged-es label Feb 4, 2020
@luisramos0
Copy link
Contributor Author

rebased to resolve minor conflicts

@luisramos0 luisramos0 merged commit 0ded41a into openfoodfoundation:master Feb 4, 2020
@luisramos0 luisramos0 deleted the backend_ctrl_orders branch February 4, 2020 11:51
@luisramos0 luisramos0 mentioned this pull request Feb 6, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants