Bring spree_backend calculator fields partial to OFN #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
changed the title
…lations instead of the spre namespace
Matt-Yorkley
approved these changes
Dec 27, 2019
mkllnk
approved these changes
Jan 8, 2020
|
Testing Notes: I then went to create a basket and got a whole lot of ugly: The page hangs in this way trying to load the whole product list. At this point the usual flow would just show the Cart. Ping @luisramos0 Not sure if this is specific to this issue or is known.... awaiting your insights :-) |
|
Calculators are working well: |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to #4050
Here we bring the code that renders the calculators selector in both the payment and shipping methods in the admin and convert it to haml.
What should we test?
We need to test the shipping method and payment method create and edit pages and make sure in both cases the selection of calculators (fees) work correctly. We need to test the forms and then maybe test one simple case where the calculator is applied and make sure what was defined in the form was applied to the order.
Release notes
Changelog Category: Changed
Brought the code to render calculators on payment and shipping methods from spree to OFN to make OFN independent of Spree.