-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring base helper from spree_backend #4588
Conversation
db88455
to
3308804
Compare
cc47e6a
to
d1987c8
Compare
Ping @luisramos0 conflicts |
d1987c8
to
5f0a9e8
Compare
rebased to resolve conflicts. ready for testing. |
…icit they are only used in the zones admin pages
5f0a9e8
to
3e68dc5
Compare
rebased to resolved conflict on rubocop file. |
This is looking good! My notes: https://docs.google.com/document/d/1vsU8Yqo9XmUVGIJQ_dm7dpdxmdroEMhcsYgH_gI9Mr8/edit# @luisramos0 I didn't find what you've meant by the footer_tos_url field . So I've tested the shopping preferences entirely. Hope this was the right place 👍 |
hmm, I meant "preferences in the general settings" but you say "shopping preferences". |
@luisramos0 not at all! I didn't know this was called preferences as well. I just tested this page. Looking good! |
sorry about that, I got taken by the names of the variables. they are all preferences in the code... |
What? Why?
Relates to #4050
In this PR we bring the base_helper from spree with a number of generic helper methods used in different parts of the application. See testing notes below for details.
What should we test?
There are couple of different things that need to be validated here.
Editing an order, in Customer Details, the placeholder should look like this translated:
field_container - product edit page looks good and works.
error_message_on - editing a product, removing name and saving it will show an error on the top of the page as well as below the name field (can be tested in english):
preference_field_tag - make sure you can edit preferences in the general settings, for example, verify the footer_tos_url field is working correctly.
zones - make sure you can add and remove countries and states from a zone: this needs to be tested for both country based zones and state based zones.
preference_fields - make sure you can configure calculators correctly on shipping_methods, payment methods and enterprise fees. everythin shouldd be fine. a quick test of the form is enough.
product properties - make sure you can add properties to a product - test the link on the top right to add more lines to the form
producer properties - make sure we can add and remove properties from a producer enterprise - this page is currently a bit weird because you can only add more properties by saving the form (it will add one if all are used) but there should be a button on the top "add properties" like in the product properties above. I think we can open a bug for this. Probably S4.
Release notes
Changelog Category: Changed
Brought base_helper with generic helper methods to build the admin pages from spree to make ofn independent of spree.