-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tax_rates, tax categories and tax settings from spree_backend to OFN #4292
Merged
luisramos0
merged 12 commits into
openfoodfoundation:master
from
luisramos0:spree_be_config_tax
Oct 2, 2019
Merged
Move tax_rates, tax categories and tax settings from spree_backend to OFN #4292
luisramos0
merged 12 commits into
openfoodfoundation:master
from
luisramos0:spree_be_config_tax
Oct 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
changed the title
Move tax_rates and tax categories from spree_backend to OFN
Move tax_rates, tax categories and tax settings from spree_backend to OFN
Sep 20, 2019
sauloperez
approved these changes
Sep 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Climate is complaining of a single failure but I'd prefer to fix later on so the commit/s that bring in this code are separated from the ones that improve it.
Matt-Yorkley
approved these changes
Sep 24, 2019
Moving to ready to go! |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Part of #4050
This moves all things related to tax_rates, tax categories and tax settings from spree_backend to OFN. No change in functionality.
What should we test?
The pages must work correctly as before.
Tax Categories: create, edit and delete tax category.
Tax rates: create, edit and delele tax rate.
Tax Settings: make sure the selections are saved.
I dont think we need to verify that these settings are working in the app, nothing as changed in the app, if these pages show the correct info, the info will be used in the app as before.
Release notes
Changelog Category: Changed
Imported views from spree_backend to make OFN more independent of Spree.