Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tax_rates, tax categories and tax settings from spree_backend to OFN #4292

Merged
merged 12 commits into from
Oct 2, 2019

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Sep 20, 2019

What? Why?

Part of #4050

This moves all things related to tax_rates, tax categories and tax settings from spree_backend to OFN. No change in functionality.

What should we test?

The pages must work correctly as before.
Tax Categories: create, edit and delete tax category.
Tax rates: create, edit and delele tax rate.
Tax Settings: make sure the selections are saved.
I dont think we need to verify that these settings are working in the app, nothing as changed in the app, if these pages show the correct info, the info will be used in the app as before.

Release notes

Changelog Category: Changed

Imported views from spree_backend to make OFN more independent of Spree.

@luisramos0 luisramos0 changed the title Move tax_rates and tax categories from spree_backend to OFN Move tax_rates, tax categories and tax settings from spree_backend to OFN Sep 20, 2019
@luisramos0 luisramos0 self-assigned this Sep 20, 2019
Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Climate is complaining of a single failure but I'd prefer to fix later on so the commit/s that bring in this code are separated from the ones that improve it.

@RachL RachL self-assigned this Oct 2, 2019
@RachL RachL added the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 2, 2019
@RachL
Copy link
Contributor

RachL commented Oct 2, 2019

  • Tax Categories: CRUD is working. Noticed the default is quite useless now as there is the "none" tax category which was hardcoded somewhere I guess and is selected by default at product creation
  • Tax rates: CRUD is working.
  • Tax Settings: selections are correctly saved.

Moving to ready to go!

@RachL RachL removed the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 2, 2019
@luisramos0 luisramos0 merged commit 9f8d2fd into openfoodfoundation:master Oct 2, 2019
@luisramos0 luisramos0 deleted the spree_be_config_tax branch October 2, 2019 14:33
@luisramos0 luisramos0 mentioned this pull request Feb 6, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants