-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deprecation Info API checks for 8.0 #42404
Comments
Pinging @elastic/es-core-features |
Curious about #25127 (comment). Are |
I don't see a PR labelled I'm also not a painless expert, but it looks like |
I was previously thinking about scripts that may end up making it into the cluster state like ML datafeed configs, but those should have migrated to persistent tasks by 8.0, so you are right, the script thing is probably not relevant here :) thx! |
The following properties have been removed from the geo_shape data type in 8.0: "strategy", "tree", "tree_levels", "precision", "distance_error_pct", "points_only". This PR adds a deprecation info API check for indexes and templates that have any of these properties in their mappings. Relates #42404 #70850
…settings (#77092) In 8.0 we prevent the server from starting up if certain SSL properties are misconfigured or ambiguous. Specifically: 1) The server lacks a certificate/key pair (i.e. neither ssl.keystore.path nor ssl.key/ssl.certificate are configured) 2) The server has some ssl configuration, but ssl.enabled is not specified. This commit adds a check to the deprecation info API for these changes. Relates #42404 #45892
Many of the URLs for deprecation info messages were broken (returned 404s), or referenced "master" or "current", which are likely to break in the future. This commit updates all of the ones that can currently be fixed. Relates #42404
This commit updates the deprecation info API to use shortened https://ela.st URLs that can be adjusted to point to different documentation URLs without having to modify the source code. Relates #42404
Pinging @elastic/es-data-management (Team:Data Management) |
This should have been closed a long time ago - 8.0 is long since out and these checks completed! |
This issue is intended to track breaking changes for 8.0 which need a deprecation check implemented in the Deprecation Info API as they are made. While we will still need a review prior to the release of 8.0, the intention is that we can work on implementing these checks as the breaking changes are made, or at least keep a running list of which ones need checks rather than having to go through all
>breaking
PRs.In order to be checkable by the Deprecation Info API, the issue must be detectable by examining one of the following:
ClusterState
IndexMetaData
DatafeedConfig
REST API changes, or problems which are only detectable by examining the contents of the index, rather than the mapping/settings, probably don't go here, but please ask if you're unsure.
Deprecation checks should generally be added to the 7.x branch. You can find the appropriate classes here. View the 6.8 branch for a number of examples if you need more examples than are present in 7.x.
The List
_field_names
enabled setting Disallow_field_names
enabled setting #46681Not needed list
Provide an Option to Use Path-Style-Access with S3 Repo Provide an Option to Use Path-Style-Access with S3 Repo #41966Blob Store compress default to true Blob Store compress default to true #40033 (is this worth warning about? not sure what this breaks)Prevent PrefixTree strategies on new geo_shape indexes [GEO] Prevent PrefixTree strategies on new geo_shape indexes #37152 (for index templates)Remove the 'template' field in index templates Remove the 'template' field in index templates. #49460Remove type metadata from ingest documents Remove type metadata from ingest documents #50131Remove support for JAVA_HOME Remove support for JAVA_HOME #69149Parse empty first line in msearch request body as action metadata Parse empty first line in msearch request body as action metadata #41011Remove deprecated endpoints containing _xpack. Remove deprecated endpoints containing _xpack. #48170Remove the object format for indices_boost Remove the object format for indices_boost. #55078Remove use_field_mapping format option for docvalue fields Remove use_field_mapping format option for docvalue fields. #55622Removes typed URLs Removes typed URLs #41636Removes tpyed endpoints for msearch and mtermvector APIs Removes tpyed endpoints for msearch and mtermvector APIs #41674Removes typed URLs from mapping APIs Removes typed URLs from mapping APIs #41676Removes types from bulk API Removes types from bulk API #42194Removes type from TermVectors APIs Removes type from TermVectors APIs #42198Remove types from Get/MultiGet Remove types from Get/MultiGet #46587Remove per-type indexing stats Remove per-type indexing stats #47203Removetype
query Removetype
query #47207Removeinclude_type_name
parameter from REST layer Removeinclude_type_name
parameter from REST layer #48632Remove support for _type in searches Remove support for _type in searches #68564Remove support for string in unmapped_type Remove support for string in unmapped_type. #45675Add declarative parameters to FieldMappers Add declarative parameters to FieldMappers #58663Don't expose TextFieldMapper subfields Don't expose TextFieldMapper subfields #64597Allow parsing Content-Type and Accept headers with version Allow parsing Content-Type and Accept headers with version #61427Highlighters skip ignored keyword values Highlighters skip ignored keyword values #53408Percentiles aggregation: disallow specifying same percentile values twice Percentiles aggregation: disallow specifying same percentile values twice #52257Fix updating include_in_parent/include_in_root of nested field Fix updating include_in_parent/include_in_root of nested field. #54386Disallow changing 'enabled' on the root mapper Disallow changing 'enabled' on the root mapper. #54463Remove TypeFieldMapper Remove TypeFieldMapper #53611Scripting: Move script_cache into _nodes/stats Scripting: Move script_cache into _nodes/stats #59265Remove the no-jdk distribution Remove no-jdk distributions for 8.0 release #65109Fix range query on date fields for number inputs Fix range query on date fields for number inputs #63692Kibana user renamed to kibana_system Deprecate the kibana reserved user; introduce kibana_system user #54967kibana_user role renamed to kibana_admin Deprecating kibana_user and kibana_dashboard_only_user roles #46456Add validation for dynamic templates Add validation for dynamic templates #51233Remove support for chained multi-fields. Remove support for chained multi-fields. #42333Enforce Completion Context Limit Enforce Completion Context Limit #38675The text was updated successfully, but these errors were encountered: