[Transform]rename classes in transform plugin #46784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
hendrikmuhs
force-pushed
the
rename-to-transform-plug-classes
branch
from
9d203e3
to
eef09a1
Compare
added 2 commits
September 18, 2019 15:19
droberts195
approved these changes
Sep 19, 2019
| @@ -41,7 +41,7 @@ private XPackSettings() { | |||
| public static final Setting<Boolean> CCR_ENABLED_SETTING = Setting.boolSetting("xpack.ccr.enabled", true, Property.NodeScope); | |||
|
|
|||
| /** Setting for enabling or disabling data frame. Defaults to true. */ | |||
| public static final Setting<Boolean> DATA_FRAME_ENABLED = Setting.boolSetting("xpack.data_frame.enabled", true, | |||
| public static final Setting<Boolean> TRANSFORM_ENABLED = Setting.boolSetting("xpack.transform.enabled", true, | |||
| Setting.Property.NodeScope); | |||
There was a problem hiding this comment.
I know we said we wouldn't provide BWC for this, but it's actually trivial to do it and it might make someone's life easier:
// TODO remove before 8.0.0 release
private static final Setting<Boolean> DATA_FRAME_ENABLED = Setting.boolSetting("xpack.data_frame.enabled", true,
Setting.Property.NodeScope, Setting.Property.Deprecated);
public static final Setting<Boolean> TRANSFORM_ENABLED = Setting.boolSetting("xpack.transform.enabled", DATA_FRAME_ENABLED,
Setting.Property.NodeScope);
The Setting class completely takes care of the deprecation warnings.
So maybe we should?
We'll have other tweaks we need to make before 8.0.0 release, such as the role names, so it's not even like this creates much work for us.
| @@ -217,7 +217,7 @@ private XPackSettings() { | |||
| settings.add(PASSWORD_HASHING_ALGORITHM); | |||
| settings.add(INDEX_LIFECYCLE_ENABLED); | |||
| settings.add(SNAPSHOT_LIFECYCLE_ENABLED); | |||
| settings.add(DATA_FRAME_ENABLED); | |||
There was a problem hiding this comment.
If you agree it's not too hard to provide BWC for this then this line should stay with a TODO to remove it before 8.0.0 release.
This was referenced Sep 19, 2019
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename classes in transform plugin