-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove include_relocations setting #47717
Remove include_relocations setting #47717
Conversation
Setting `cluster.routing.allocation.disk.include_relocations` to `false` is a bad idea since it will lead to the kinds of overshoot that were otherwise fixed in elastic#46079. This setting was deprecated in elastic#47443. This commit removes it.
Pinging @elastic/es-distributed (:Distributed/Allocation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I opened #47718 for the CI failure. @elasticmachine please run elasticsearch-ci/docs-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
* First pass of spec update to OSS plugin * Update existing doc links * Move data_frame files to new depreceated namespace * Removing this setting per elastic/elasticsearch#47717 * Add new files * Added transforms overrides * Updated deprecated data transforms file names Fixed broken __template's Updated autocomplete for new transforms endpoints
* First pass of spec update to OSS plugin * Update existing doc links * Move data_frame files to new depreceated namespace * Removing this setting per elastic/elasticsearch#47717 * Add new files * Added transforms overrides * Updated deprecated data transforms file names Fixed broken __template's Updated autocomplete for new transforms endpoints
* First pass of spec update to OSS plugin * Update existing doc links * Move data_frame files to new depreceated namespace * Removing this setting per elastic/elasticsearch#47717 * Add new files * Added transforms overrides * Updated deprecated data transforms file names Fixed broken __template's Updated autocomplete for new transforms endpoints
…ELOCATIONS_SETTING Relates elastic#47717
Setting
cluster.routing.allocation.disk.include_relocations
tofalse
is abad idea since it will lead to the kinds of overshoot that were otherwise fixed
in #46079. This setting was deprecated in #47443. This commit removes it.