-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate unused Zen1 settings #38289
Merged
DaveCTurner
merged 1 commit into
elastic:master
from
DaveCTurner:2019-02-03-deprecate-zen-settings
Feb 4, 2019
Merged
Deprecate unused Zen1 settings #38289
DaveCTurner
merged 1 commit into
elastic:master
from
DaveCTurner:2019-02-03-deprecate-zen-settings
Feb 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the following settings in the `discovery.zen` namespace are still used: - `discovery.zen.no_master_block` - `discovery.zen.hosts_provider` - `discovery.zen.ping.unicast.concurrent_connects` - `discovery.zen.ping.unicast.hosts.resolve_timeout` - `discovery.zen.ping.unicast.hosts` This commit deprecates all other settings in this namespace so that they can be removed in the next major version.
DaveCTurner
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
labels
Feb 3, 2019
Pinging @elastic/es-distributed |
61 tasks
ywelsch
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In a follow-up, let's add new settings for these remaining ones in a different namespace, deprecate these 5 and default the new ones to the deprecated ones.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 7, 2021
Zen discovery and its associated settings were deprecated in 7.0. This commit adds an entry to the release notes calling this out. Relates elastic#38289 elastic#38333 elastic#38350 elastic#37868
DaveCTurner
added a commit
that referenced
this pull request
Oct 7, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
>non-issue
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the following settings in the
discovery.zen
namespace are still used:discovery.zen.no_master_block
discovery.zen.hosts_provider
discovery.zen.ping.unicast.concurrent_connects
discovery.zen.ping.unicast.hosts.resolve_timeout
discovery.zen.ping.unicast.hosts
This commit deprecates all other settings in this namespace so that they can be
removed in the next major version.