Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename no-master-block setting #38350

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Rename no-master-block setting #38350

merged 2 commits into from
Feb 5, 2019

Conversation

DaveCTurner
Copy link
Contributor

Replaces discovery.zen.no_master_block with cluster.no_master_block. Any
value set for the old setting is now ignored.

@DaveCTurner
Rename no-master-block setting
aa905b7 
Replaces `discovery.zen.no_master_block` with `cluster.no_master_block`. Any
value set for the old setting is now ignored.
@DaveCTurner DaveCTurner added >breaking >non-issue v7.0.0 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Feb 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch ywelsch mentioned this pull request Feb 4, 2019
Closed
61 tasks
@DaveCTurner
Copy link
Contributor Author

FAO @gwbrown as this is a breaking change. We explored a number of options for renaming this dynamic setting so as to fall back to the legacy setting name but all had drawbacks. Since this setting is very rarely adjusted, and only takes effect when the cluster is broken, we opted simply to start ignoring it in favour of the new name.

ywelsch
ywelsch approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/src/main/java/org/elasticsearch/cluster/coordination/Coordinator.java
@@ -103,7 +102,7 @@
private final JoinHelper joinHelper;
private final NodeRemovalClusterStateTaskExecutor nodeRemovalExecutor;
private final Supplier<CoordinationState.PersistedState> persistedStateSupplier;
private final DiscoverySettings discoverySettings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@gwbrown gwbrown mentioned this pull request Feb 4, 2019
Closed
26 tasks
@gwbrown
Copy link
Contributor

gwbrown commented Feb 4, 2019

Thanks for the ping @DaveCTurner, I've added this to the list at #36024. This looks like a setting that would typically be set via the cluster settings API (rather than elasticsearch.yml), correct?

@DaveCTurner
Copy link
Contributor Author

This looks like a setting that would typically be set via the cluster settings API (rather than elasticsearch.yml), correct?

TBH the overwhelmingly typical case is that this setting isn't set at all. I don't think we can say whether it's more or less likely to be set as a cluster setting vs a node setting.

@gwbrown gwbrown mentioned this pull request Feb 5, 2019
Merged
@DaveCTurner DaveCTurner merged commit 3b2a0d7 into elastic:master Feb 5, 2019
@DaveCTurner DaveCTurner deleted the 2019-02-04-rename-no-master-block-setting branch February 5, 2019 08:48
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019
@jasontedor
Merge branch 'master' into simplify-retention-lease-expiration
ff9520e 
* master:
  Mute failing API key integration test (elastic#38409)
  Change the milliseconds precision to 3 digits for intervals. (elastic#38297)
  SecuritySettingsSource license.self_generated: trial (elastic#38233)
  Rename no-master-block setting (elastic#38350)
  Rename static Zen1 settings (elastic#38333)
  Migration doc for audit json log file (elastic#38165)
  Add apm_user reserved role (elastic#38206)
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Feb 6, 2019
@DaveCTurner
Align docs etc with new discovery setting names
c014dcf 
In elastic#38333 and elastic#38350 we moved away from the `discovery.zen` settings namespace
since these settings have an effect even though Zen Discovery itself is being
phased out. This change aligns the documentation and the names of related
classes and methods with the newly-introduced naming conventions.
@DaveCTurner DaveCTurner mentioned this pull request Feb 6, 2019
Merged
DaveCTurner added a commit that referenced this pull request Feb 6, 2019
@DaveCTurner
Align docs etc with new discovery setting names (#38492)
5a3c452 
In #38333 and #38350 we moved away from the `discovery.zen` settings namespace
since these settings have an effect even though Zen Discovery itself is being
phased out. This change aligns the documentation and the names of related
classes and methods with the newly-introduced naming conventions.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 7, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated
03be471 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates elastic#38289 elastic#38333 elastic#38350 elastic#37868
@DaveCTurner DaveCTurner mentioned this pull request Oct 7, 2021
Merged
DaveCTurner added a commit that referenced this pull request Oct 7, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
f0a8842 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
082c6f8 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
60ea35d 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
3746d97 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
7f69ac3 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
88da0a7 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
710454c 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
8089410 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
@DaveCTurner
Document that discovery.zen.* settings are deprecated (#78824)
ddb8c23 
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@andrershov andrershov Awaiting requested review from andrershov

Assignees
No one assigned
Labels
>breaking :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaveCTurner @elasticmachine @gwbrown @ywelsch @colings86