Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration doc for audit json log file #38165

Merged
merged 5 commits into from
Feb 5, 2019

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Feb 1, 2019

The migration documentation for an audit logging changes. Removal of plaintext logs and rename of json log file

relates #32850

Since the name of the audit log file was changed it should be documented
in a migration doc.

relates elastic#32850
@pgomulka pgomulka self-assigned this Feb 1, 2019
@pgomulka pgomulka added :Core/Infra/Logging Log management and logging utilities :Security/Audit X-Pack Audit logging labels Feb 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pgomulka pgomulka added the >docs General docs changes label Feb 1, 2019
[float]
==== Audit plaintext log file removed, JSON file renamed

Elasticsearch will no longer produce a plaintext audit log file `${cluster_name}_access.log`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "will" makes me wonder if this is something happening in the future or is already true for this version. If the latter, I'd change it to "Elasticsearch no longer produces...".


Elasticsearch will no longer produce a plaintext audit log file `${cluster_name}_access.log`.
The JSON log file should be used instead. The name of this file was changed from
`${cluster_name}_audit.log` to `${cluster_name}_audit.json`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`${cluster_name}_audit.log` to `${cluster_name}_audit.json`.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 89feaa0 into elastic:master Feb 5, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019
* master:
  Mute failing API key integration test (elastic#38409)
  Change the milliseconds precision to 3 digits for intervals. (elastic#38297)
  SecuritySettingsSource license.self_generated: trial (elastic#38233)
  Rename no-master-block setting (elastic#38350)
  Rename static Zen1 settings (elastic#38333)
  Migration doc for audit json log file (elastic#38165)
  Add apm_user reserved role (elastic#38206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities >docs General docs changes :Security/Audit X-Pack Audit logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants