Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation check for Java version #41092

Closed
wants to merge 1 commit into from

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Apr 10, 2019

Adds a deprecation check for Java version, as Java 11 will be required
in the next version of Elasticsearch.

Relates to #40756 and #40754


Marked as a draft because this will cause test failures when running on jdk8, as there exist tests which assume there are no deprecation warnings under normal testing circumstances.

Adds a deprecation check for Java version, as Java 11 will be required
in the next version of Elasticsearch.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@gwbrown
Copy link
Contributor Author

gwbrown commented Sep 5, 2019

This has been sitting idle for a while, and given 1) the difficulties testing this, and especially 2) the fact that our default download bundles a JDK now, this is unlikely to be an issue that most customers will run into. We can revisit this leading up to the release of the next major version if necessary.

@gwbrown gwbrown closed this Sep 5, 2019
@jasontedor
Copy link
Member

@gwbrown I think that we can add an exclusion to the test framework for this specific deprecation (as we've done, for example with the migration to one shard in the past). I do think that we should have this deprecation check, as a major JDK version upgrade can be a hurdle for some users, we should notify them of that change as soon as possible.

@gwbrown
Copy link
Contributor Author

gwbrown commented Sep 5, 2019

@jasontedor Thanks for the input - you're more familiar with what users have difficulties with, so I'll reopen and work on updating this PR.

@gwbrown gwbrown reopened this Sep 5, 2019
@jimczi jimczi added v7.6.0 and removed v7.5.0 labels Nov 12, 2019
@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@bpintea bpintea added v7.8.0 and removed v7.7.0 labels Mar 25, 2020
@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@gwbrown
Copy link
Contributor Author

gwbrown commented Nov 12, 2020

Closing in favor of #64996

@gwbrown gwbrown closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Team:Data Management Meta label for data/management team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.