Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove per-type indexing stats #47203

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Remove per-type indexing stats #47203

merged 3 commits into from
Sep 27, 2019

Conversation

romseygeek
Copy link
Contributor

With only a single type, the per-type filters for indexing stats are no longer useful.

Relates to #41059

@romseygeek romseygeek added >breaking :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 labels Sep 27, 2019
@romseygeek romseygeek self-assigned this Sep 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@romseygeek
Copy link
Contributor Author

I will open a separate PR against 7x to deprecate the types parameter on NodeStatsRequest

@romseygeek
Copy link
Contributor Author

@elasticmachine update branch

colings86
colings86 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit ff99bc1 into elastic:master Sep 27, 2019
@romseygeek romseygeek deleted the types-removal/internal-indexing-stats branch September 27, 2019 12:03
@jpountz jpountz mentioned this pull request Sep 27, 2019
Closed
66 tasks
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
Closed
66 tasks
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jun 16, 2021
@pgomulka
[Rest Api Compatibility] Typed indexing stats
3b3b2bd 
the per type indexing stats is simplified and when _types is requested
it will return total stats for the index repeated under types/_doc/

the removal elastic#47203

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka mentioned this pull request Jun 16, 2021
Merged
pgomulka added a commit that referenced this pull request Jun 17, 2021
@pgomulka
[Rest Api Compatibility] Typed indexing stats (#74181)
fdc301f 
the per type indexing stats is simplified and when _types is requested
it will return total stats for the index repeated under types/_doc/

the removal #47203

relates main meta issue #51816
relates types removal issue #54160
@masseyke masseyke mentioned this pull request Aug 9, 2021
Closed
80 tasks
@jrodewig jrodewig mentioned this pull request Sep 27, 2021
Merged
jrodewig added a commit that referenced this pull request Sep 28, 2021
@jrodewig
[DOCS] Remove index API's types option (#78335)
0c01bcd 
Adds an 8.0 breaking change for PR #47203.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colings86 colings86 colings86 approved these changes

@dnhatn dnhatn Awaiting requested review from dnhatn

Assignees

@romseygeek romseygeek

Labels
>breaking :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romseygeek @elasticmachine @colings86 @jakelandis