Adding deprecation info API message for sparse_vector #77381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-data-management (Team:Data Management) |
jbaiera
approved these changes
Sep 7, 2021
| ClusterDeprecationChecks::formatDeprecatedSparseVectorMessage); | ||
| if (messages.isEmpty() == false) { | ||
| String messageForMapping = | ||
| "mappings in component template " + templateName + " contains deprecated sparse_vector fields: " + |
There was a problem hiding this comment.
lets surround the template name in some kind of quotations or punctuation so that it's easier to see as a resource name instead of just text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sparse_vector type is deprecated and has been removed in 8.0. This commit adds a deprecation info API
message if we detect templates with mappings that include sparse_vector fields.
Relates #42404 #48781