Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate xpack.watcher.history.cleaner_service.enabled #37782

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jan 23, 2019

This deprecates the xpack.watcher.history.cleaner_service.enabled setting,
since all newly created .watch-history indices in 7.0 will use ILM to manage
their retention.

In 8.0 the setting itself and cleanup actions will be removed.

Resolves #32041

This deprecates the `xpack.watcher.history.cleaner_service.enabled` setting,
since all newly created `.watch-history` indices in 7.0 will use ILM to manage
their retention.

In 8.0 the setting itself and cleanup actions will be removed.

Resolves elastic#32041
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@gwbrown
Copy link
Contributor

gwbrown commented Jan 23, 2019

Could you also add a deprecation check for this setting?

@dakrone
Copy link
Member Author

dakrone commented Jan 24, 2019

@gwbrown not sure what you mean exactly? Marking the setting as deprecated I believe causes logging for deprecation when the setting is set

@gwbrown
Copy link
Contributor

gwbrown commented Jan 24, 2019

@dakrone Sorry, I meant in the Deprecations API, similar to #36185 - I'd like to make this automatically catch deprecated settings, but until then it's a manual process.

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - After discussion with @dakrone we've decided to not add a deprecation check to this PR as it will likely be addressed by other planned improvements to the Deprecations API.

@dakrone dakrone merged commit 0f3c542 into elastic:master Jan 24, 2019
@dakrone dakrone deleted the deprecate-watch-history-cleaner branch February 4, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants