-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding deprecation logging and deprecation info API for ILM freeze ation #77969
Adding deprecation logging and deprecation info API for ILM freeze ation #77969
Conversation
Pinging @elastic/es-data-management (Team:Data Management) |
@elasticmachine update branch |
These messages mention that the freeze action has been deprecated in favor of the frozen tier, but that is incorrect. Actually, frozen indices are no longer necessary due to heap improvements (see the header on https://www.elastic.co/guide/en/elasticsearch/reference/7.14/freeze-index-api.html for an example of how we describe it in the documentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though, is it expected that the current link to the documentation does not work? Has it just not been set up yet?
Yeah I have a script to generate those links once the documentation is written. Related, @jakelandis told me that you and he will be writing that documentation @dakrone. |
@masseyke - I did indeed say that :) However, after re-review of how the documentation is arranged, can you link to information similar to https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_ilm_changes, but inline with the other links (i.e. per version of when the deprecation was introduced). The removal of the API will have it's own entry and pointing to just the ILM doc I think makes sense here since the warning is just about ILM. |
Fixing.a random test failure where the deprecated freeze action is sometimes used when creating an ILM phase Relates #77969
As part of deprecating frozen indices in favor of the frozen tier, this commit deprecates the ILM freeze action. This
includes a deprecation log message at runtime, as well as a deprecation info API check.
Relates #70192 #42404