Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation logging and deprecation info API for ILM freeze ation #77969

Merged
merged 7 commits into from
Sep 21, 2021

Conversation

masseyke
Copy link
Member

As part of deprecating frozen indices in favor of the frozen tier, this commit deprecates the ILM freeze action. This
includes a deprecation log message at runtime, as well as a deprecation info API check.
Relates #70192 #42404

@masseyke masseyke added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Sep 16, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Sep 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke
Copy link
Member Author

@elasticmachine update branch

@dakrone
Copy link
Member

dakrone commented Sep 20, 2021

These messages mention that the freeze action has been deprecated in favor of the frozen tier, but that is incorrect. Actually, frozen indices are no longer necessary due to heap improvements (see the header on https://www.elastic.co/guide/en/elasticsearch/reference/7.14/freeze-index-api.html for an example of how we describe it in the documentation)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though, is it expected that the current link to the documentation does not work? Has it just not been set up yet?

@masseyke
Copy link
Member Author

LGTM, though, is it expected that the current link to the documentation does not work? Has it just not been set up yet?

Yeah I have a script to generate those links once the documentation is written. Related, @jakelandis told me that you and he will be writing that documentation @dakrone.

@masseyke masseyke merged commit dfc9a8e into elastic:7.x Sep 21, 2021
@masseyke masseyke deleted the feature/deprecation-freeze-action branch September 21, 2021 22:13
@jakelandis
Copy link
Contributor

jakelandis commented Sep 21, 2021

@masseyke - I did indeed say that :) However, after re-review of how the documentation is arranged, can you link to information similar to https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_ilm_changes, but inline with the other links (i.e. per version of when the deprecation was introduced). The removal of the API will have it's own entry and pointing to just the ILM doc I think makes sense here since the warning is just about ILM.

@masseyke masseyke mentioned this pull request Sep 22, 2021
masseyke added a commit that referenced this pull request Sep 22, 2021
Fixing.a random test failure where the deprecated freeze action is sometimes used when creating an ILM phase
Relates #77969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >deprecation Team:Data Management Meta label for data/management team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants