Adding a deprecation info check for fixed_auto_queue_size threadpool settings #76995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
80 tasks
jbaiera
approved these changes
Sep 1, 2021
| @@ -595,4 +595,40 @@ static DeprecationIssue checkClusterRoutingAllocationIncludeRelocationsSetting(f | |||
| DeprecationIssue.Level.CRITICAL | |||
| ); | |||
| } | |||
|
|
|||
| static DeprecationIssue checkFixedAutoQueueSizeThreadpool(final Settings settings, | |||
There was a problem hiding this comment.
Should this function be added to the DeprecationChecks file?
There was a problem hiding this comment.
Oh wow yeah definitely. Thanks for catching it. Done.
masseyke
deleted the
feature/deprecation-info-fixed-auto-queue-size-threadpool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixed_auto_queue_size threadpool has been removed in 8.0. This commit checks for configuration that is
specific to that threadpool type and issues a deprecation info API message about it.
Relates #42404 #52280