Adding a deprecation info API check for fractional byte value settings #77074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
jbaiera
approved these changes
Sep 2, 2021
| Map<String, String> fractionalByteSettings = new HashMap<>(); | ||
| for (String key : settings.keySet()) { | ||
| try { | ||
| settings.getAsBytesSize(key, ByteSizeValue.ZERO); |
There was a problem hiding this comment.
This looks like it triggers deprecation logging as well for each fractional value read, do we want that?
| if (stringValue.contains(".")) { | ||
| fractionalByteSettings.put(key, stringValue); | ||
| } | ||
| } catch (Exception ignoreThis) { |
There was a problem hiding this comment.
Hmm, I'm not a huge fan of Exception based control flow. I know that settings are registered with ClusterSettings and IndexScopedSettings so that settings can be validated against the master set, but I don't know if we can filter on the setting's data type due to type erasure, and I'm not sure if those are comprehensive for every setting either.
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6.2.0 we deprecated support for fractional byte value settings. Support was originally going to be
removed altogether in 8.0.0 (see #53927) but that PR was not merged. This commit adds a warning
deprecation info check if any fractional byte values settings are found.
Relates #42404