-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate xpack.eql.enabled setting and make it a no-op #61375
Merged
williamrandolph
merged 5 commits into
elastic:master
from
williamrandolph:deprecate-eql-setting
Sep 16, 2020
Merged
Deprecate xpack.eql.enabled setting and make it a no-op #61375
williamrandolph
merged 5 commits into
elastic:master
from
williamrandolph:deprecate-eql-setting
Sep 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamrandolph
added
:Core/Infra/Plugins
Plugin API and infrastructure
>deprecation
v8.0.0
Team:Core/Infra
Meta label for core/infra team
v7.10.0
v7.9.1
labels
Aug 20, 2020
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
rjernst
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/1 |
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Sep 16, 2020
* Deprecate xpack.eql.enabled and make it a no-op * Remove uses of xpack.eql.enabled
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Core/Infra/Plugins
Plugin API and infrastructure
>deprecation
Team:Core/Infra
Meta label for core/infra team
v7.9.2
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently removed the
xpack.*.enabled
settings for basic license level features (#54745). However, that work was being done simultaneously with EQL work, so thexpack.eql.enabled
setting didn't get included in this work.This PR deprecates the setting. It will be removed in a follow-up PR. Since the feature is experimental and the
xpack.eql.enabled
setting is undocumented, I don't know if the removal needs to be officially documented.