Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate xpack.eql.enabled setting and make it a no-op #61375

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

williamrandolph
Copy link
Contributor

We have recently removed the xpack.*.enabled settings for basic license level features (#54745). However, that work was being done simultaneously with EQL work, so the xpack.eql.enabled setting didn't get included in this work.

This PR deprecates the setting. It will be removed in a follow-up PR. Since the feature is experimental and the xpack.eql.enabled setting is undocumented, I don't know if the removal needs to be officially documented.

@williamrandolph williamrandolph added :Core/Infra/Plugins Plugin API and infrastructure >deprecation v8.0.0 Team:Core/Infra Meta label for core/infra team v7.10.0 v7.9.1 labels Aug 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz added v7.9.2 and removed v7.9.1 labels Sep 1, 2020
@williamrandolph
Copy link
Contributor Author

@elasticmachine update branch

@williamrandolph
Copy link
Contributor Author

@elasticmachine update branch

@williamrandolph
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/1

@williamrandolph williamrandolph merged commit 035dfce into elastic:master Sep 16, 2020
williamrandolph added a commit to williamrandolph/elasticsearch that referenced this pull request Sep 16, 2020
* Deprecate xpack.eql.enabled and make it a no-op
* Remove uses of xpack.eql.enabled
williamrandolph added a commit that referenced this pull request Sep 17, 2020
)

* Deprecate xpack.eql.enabled and make it a no-op
* Remove uses of xpack.eql.enabled
@williamrandolph williamrandolph deleted the deprecate-eql-setting branch May 23, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure >deprecation Team:Core/Infra Meta label for core/infra team v7.9.2 v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants