Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to disable BASIC licensed features #54745

Closed
1 task done
williamrandolph opened this issue Apr 3, 2020 · 3 comments
Closed
1 task done

Remove the ability to disable BASIC licensed features #54745

williamrandolph opened this issue Apr 3, 2020 · 3 comments
Assignees
Labels
:Core/Infra/Plugins Plugin API and infrastructure Meta Team:Core/Infra Meta label for core/infra team

Comments

@williamrandolph
Copy link
Contributor

williamrandolph commented Apr 3, 2020

Many of our basic-license features are important building blocks of higher-level features. For example, Machine Learning can use Index Lifecycle Management to easily manage internal indices. However, if it's possible to disable these basic plugins, then the higher-level features need to account for the case when the basic plugins are disabled, and sometimes even re-implement what those plugins can do in the case that the lower-level plugins are disabled. Further, allowing these settings to be disabled on a per-node basis leads to the unfortunate situation of inconsistent settings on different nodes.

The basic plugins in question are enrich, eql, flattened, ilm, monitoring, rollup, slm, sql, transform, and vectors. Note that the security plugin is not included here; it's a complex case and won't be considered in this ticket.

Some of these plugins have a switch for enabling or disabling because we wanted to protect against bugs in early releases. However, as these features mature, they can become important dependencies of newer features, and we reach a "point of no return" where the ability to disable the feature is more of a
risk than the potential for bugs in the feature.

The plan, then, is as follows (quoting @jasontedor):

In 8.0 all Basic-licensed features are enabled in the default distribution, there will not be any settings to disable them, and Stack and Solutions developers can rely on them being enabled. In 7.x we will deprecate the ability to set these settings, and in 8.0 we will remove these settings.

  • make sure deprecation warnings appear in _migration/deprecations endpoint
@williamrandolph williamrandolph added :Core/Infra/Plugins Plugin API and infrastructure Meta labels Apr 3, 2020
@williamrandolph williamrandolph self-assigned this Apr 3, 2020
@rjernst rjernst changed the title Remove the ability to disable basic plugins Remove the ability to disable BASIC licensed features Apr 3, 2020
@jasontedor jasontedor reopened this Apr 4, 2020
@williamrandolph
Copy link
Contributor Author

williamrandolph commented Apr 8, 2020

I should note that removing the ability to disable slm may bring back some issues we have seen in testing: #50302

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
danielmitterdorfer added a commit to elastic/rally-teams that referenced this issue May 6, 2020
With this commit we remove the setting `xpack_monitoring_enabled` as it
has been removed in Elasticsearch master.

Relates elastic/elasticsearch#54745
@williamrandolph
Copy link
Contributor Author

I need to make sure that these deprecation warnings appear in the upgrade assistant. That will take one more PR.

@williamrandolph
Copy link
Contributor Author

I've fixed the upgrade assistant issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure Meta Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

3 participants