Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 6.0 branch into main #11521

Merged
merged 55 commits into from
Aug 21, 2024
Merged

Merge 6.0 branch into main #11521

merged 55 commits into from
Aug 21, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 21, 2024

Release Note Template for Downstream PRs (will be copied)


c2thorn and others added 30 commits June 25, 2024 16:43
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 7/1
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 7/9
…hanges (min_instances, max_instances, min_throughput, max_throughput fields) (GoogleCloudPlatform#10313)
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 7/16
…w required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service (GoogleCloudPlatform#9581)
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 7/23
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 8/1
…n-FEATURE-BRANCH-6.0.0

# Conflicts:
#	mmv1/third_party/terraform/services/cloudrunv2/resource_cloud_run_v2_job_test.go.erb
#	mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.erb
#	mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go
#	mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown
c2thorn and others added 16 commits August 15, 2024 12:15
…n-FEATURE-BRANCH-6.0.0

# Conflicts:
#	mmv1/products/compute/Subnetwork.yaml
#	mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.erb
#	mmv1/third_party/terraform/services/storage/resource_storage_bucket_600_migration.go
#	mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_cluster_test.go
#	mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_external_address_test.go
#	mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_network_peering_test.go
#	mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_network_policy_test.go
#	mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 8/20
…n-FEATURE-BRANCH-6.0.0

* commit 'bc5def9f8136003836911e78567dc8849a39be6d':
  Fix test `TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule` (GoogleCloudPlatform#11469)
  Promoted labelFingerprint field to GA (GoogleCloudPlatform#11504)
  Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#11485)
  Support Undelete for Vmwareengine Private Cloud (GoogleCloudPlatform#11480)
…EATURE-BRANCH-6.0.0

Sync main feature branch 6.0.0 - 8/21
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 331 files changed, 3302 insertions(+), 4049 deletions(-))
google-beta provider: Diff ( 352 files changed, 3598 insertions(+), 4111 deletions(-))
terraform-google-conversion: Diff ( 32 files changed, 141 insertions(+), 531 deletions(-))
Open in Cloud Shell: Diff ( 28 files changed, 51 insertions(+), 20 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field allow_resource_tags_on_deletion within resource google_bigquery_table was either removed or renamed - reference
  • Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
  • Field certificate_id became Computed only on google_compute_managed_ssl_certificate - reference
  • Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
  • Field create_sample_workflows within resource google_integrations_client was either removed or renamed - reference
  • Field deletion_policy default value changed from DELETE to PREVENT on google_project - reference
  • Field host.gce_instance.disable_ssh default value changed from to true on google_workstations_workstation_config - reference
  • Field lifecycle_rule.condition.no_age within resource google_storage_bucket was either removed or renamed - reference
  • Field lifecycle_rule.condition.send_age_if_zero default value changed from true to on google_storage_bucket - reference
  • Field max_throughput default value changed from 300 to on google_vpc_access_connector - reference
  • Field min_throughput default value changed from 200 to on google_vpc_access_connector - reference
  • Field monitoring_config.advanced_datapath_observability_config.enable_relay changed from optional to required on google_container_cluster - reference
  • Field monitoring_config.advanced_datapath_observability_config.enable_relay default value changed from false to on google_container_cluster - reference
  • Field monitoring_config.advanced_datapath_observability_config.relay_mode within resource google_container_cluster was either removed or renamed - reference
  • Field multi_region_auxiliary within resource google_bigquery_reservation was either removed or renamed - reference
  • Field network within resource google_alloydb_cluster was either removed or renamed - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference
  • Field provision_gmek within resource google_integrations_client was either removed or renamed - reference
  • Field schema_settings transitioned from optional+computed to optional google_pubsub_topic - reference
  • Field skip_delete within resource google_project was either removed or renamed - reference
  • Field template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_service - reference
  • Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference
  • Field template.template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_job - reference
  • Resource google_datastore_index was either removed or renamed - reference
  • Resource google_identity_platform_project_default_config was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_network (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_network" "primary" {
  labels = # value needed
}

Resource: google_edgenetwork_subnet (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_subnet" "primary" {
  labels = # value needed
}

Resource: google_sql_database_instance (125 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      enable_private_path_for_google_cloud_services = # value needed
      require_ssl                                   = # value needed
      server_ca_mode                                = # value needed
    }
  }
}

@c2thorn c2thorn added the override-breaking-change Allows a potential breaking change to be merged label Aug 21, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3902
Passed tests: 3486
Skipped tests: 403
Affected tests: 13

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccContainerCluster_withProviderDefaultLabels
  • TestAccVPCAccessConnector_vpcAccessConnectorThroughput_combiningThroughputAndInstancesFields_conflict

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_firestore
  • TestAccComputeDisk_storagePoolSpecified
  • TestAccComputeInstance_bootDisk_storagePoolSpecified
  • TestAccComputeInstance_confidentialHyperDiskBootDisk
  • TestAccComputeNetworkFirewallPolicyRule_multipleRules
  • TestAccContainerClusterDatasource_regional
  • TestAccDataformRepository_updated
  • TestAccDataprocVirtualCluster_basic
  • TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update
  • TestAccKmsCryptoKey_keyAccessJustificationsPolicy
  • TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample
  • TestAccSecurityCenterFolderNotificationConfig_basic
  • TestAccSecurityCenterV2FolderNotificationConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataformRepository_updated[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_firestore[Error message] [Debug log]
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_confidentialHyperDiskBootDisk[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerClusterDatasource_regional[Error message] [Debug log]
TestAccDataprocVirtualCluster_basic[Error message] [Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update[Error message] [Debug log]
TestAccKmsCryptoKey_keyAccessJustificationsPolicy[Error message] [Debug log]
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample[Error message] [Debug log]
TestAccSecurityCenterFolderNotificationConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderNotificationConfig_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.