Remove references to deprecated google_datastore_index feature.

[vadimyushprakh]

Remove references to deprecated google_datastore_index feature.

Googlers, see b/347992152

fixes hashicorp/terraform-provider-google#19149

Release Note Template for Downstream PRs (will be copied)

datastore: `google_datastore_index` has been removed in favor of `google_firestore_index`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2 insertions(+), 955 deletions(-))
google-beta provider: Diff ( 6 files changed, 2 insertions(+), 954 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 122 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_datastore_index was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datastore

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[hao-nan-li]

Could you also add an entry in this 6.0.0 changelog? https://github.com/GoogleCloudPlatform/magic-modules/blob/FEATURE-BRANCH-major-release-6.0.0/mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown

[c2thorn]

Could you also add an entry in this 6.0.0 changelog? FEATURE-BRANCH-major-release-6.0.0/mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown

Yes and please mention what users are supposed to use instead of google_datastore_index in the upgrade guide and release note. (with the breaking-change tag instead of deprecation)

[vadimyushprakh]

Addressed PR feedback: updated description to breaking-change and added an entry to version_6_upgrade.html.markdown

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 7 insertions(+), 956 deletions(-))
google-beta provider: Diff ( 7 files changed, 7 insertions(+), 955 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 122 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_datastore_index was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datastore

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 7 insertions(+), 956 deletions(-))
google-beta provider: Diff ( 7 files changed, 7 insertions(+), 955 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 122 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_datastore_index was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datastore

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[hao-nan-li]

Looks like you removed the only resource from the datastore product, could you remove the entire product?

[vadimyushprakh]

Looks like you removed the only resource from the datastore product, could you remove the entire product?

Removed. Thank you!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 7 insertions(+), 989 deletions(-))
google-beta provider: Diff ( 13 files changed, 7 insertions(+), 989 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 122 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_datastore_index was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 3895
Passed tests: 3503
Skipped tests: 384
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApikeysKey_AndroidKey
• TestAccApikeysKey_BasicKey
• TestAccApikeysKey_IosKey
• TestAccApikeysKey_MinimalKey
• TestAccApikeysKey_ServerKey
• TestAccComputeInstance_bootDisk_storagePoolSpecified
• TestAccDataSourceArtifactRegistryDockerImage
• TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccApikeysKey_AndroidKey[Error message] [Debug log]
TestAccApikeysKey_BasicKey[Error message] [Debug log]
TestAccApikeysKey_IosKey[Error message] [Debug log]
TestAccApikeysKey_MinimalKey[Error message] [Debug log]
TestAccApikeysKey_ServerKey[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test