Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deprecated google_datastore_index feature. #11457

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 0 additions & 97 deletions mmv1/products/datastore/Index.yaml

This file was deleted.

112 changes: 0 additions & 112 deletions mmv1/products/datastore/go_Index.yaml

This file was deleted.

34 changes: 0 additions & 34 deletions mmv1/products/datastore/go_product.yaml

This file was deleted.

38 changes: 0 additions & 38 deletions mmv1/products/datastore/product.yaml

This file was deleted.

26 changes: 0 additions & 26 deletions mmv1/templates/terraform/examples/datastore_index.tf.erb

This file was deleted.

26 changes: 0 additions & 26 deletions mmv1/templates/terraform/examples/go/datastore_index.tf.tmpl

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ and then run `terraform apply` to apply the change.

### `lifecycle_rule.condition.no_age` is now removed

Previously `lifecycle_rule.condition.age` attirbute was being set zero value by default and `lifecycle_rule.condition.no_age` was introduced to prevent that.
Previously `lifecycle_rule.condition.age` attribute was being set zero value by default and `lifecycle_rule.condition.no_age` was introduced to prevent that.
Now `lifecycle_rule.condition.no_age` is no longer supported and `lifecycle_rule.condition.age` won't set a zero value by default.
Removed in favor of the field `lifecycle_rule.condition.send_age_if_zero` which can be used to set zero value for `lifecycle_rule.condition.age` attribute.

Expand Down Expand Up @@ -346,3 +346,7 @@ explicitly set this field to `DELETE` in your configuration and run `terraform a
`skip_delete` value of `false` can be changed to a `deletion_policy` value of `DELETE` and
a `skip_delete` value of `true` to a `deletion_policy` value of `ABANDON` for equivalent
behavior.

### Resource: `google_datastore_index` is now removed

`google_datastore_index` is removed in favor of `google_firestore_index`
1 change: 0 additions & 1 deletion tools/issue-labeler/labeler/enrolled_teams.yml
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,6 @@ service/firestore-controlplane:
- google_firestore_database
service/firestore-dataplane:
resources:
- google_datastore_index
- google_firestore_document
- google_firestore_field
- google_firestore_index
Expand Down
Loading