Remove network in google_alloydb_cluster

[NickElliot]

Fixes hashicorp/terraform-provider-google#16119

Release Note Template for Downstream PRs (will be copied)

alloydb: `network` removed in `google_alloy_db_cluster`. Use `network_config.network` instead.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 296 insertions(+), 157 deletions(-))
google-beta provider: Diff ( 15 files changed, 296 insertions(+), 157 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 7 files changed, 24 insertions(+), 11 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field network within resource google_alloydb_cluster was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 67
Passed tests: 16
Skipped tests: 4
Affected tests: 47

Click here to see the affected service packages

• alloydb

Action taken

Found 47 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbBackup_alloydbBackupBasicTestExample
• TestAccAlloydbBackup_createBackupWithMandatoryFields
• TestAccAlloydbBackup_update
• TestAccAlloydbBackup_usingCMEK
• TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight
• TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable
• TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser
• TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample
• TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable
• TestAccAlloydbCluster_continuousBackup_enabledByDefault
• TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved
• TestAccAlloydbCluster_continuousBackup_update
• TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet
• TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser
• TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy
• TestAccAlloydbCluster_missingWeeklySchedule
• TestAccAlloydbCluster_restore
• TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary
• TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig
• TestAccAlloydbCluster_secondaryClusterPromote
• TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser
• TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig
• TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary
• TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy
• TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate
• TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate
• TestAccAlloydbCluster_secondaryClusterUpdate
• TestAccAlloydbCluster_secondaryClusterUsingCMEK
• TestAccAlloydbCluster_update
• TestAccAlloydbCluster_usingCMEK
• TestAccAlloydbInstance_alloydbInstanceBasicTestExample
• TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample
• TestAccAlloydbInstance_clientConnectionConfig
• TestAccAlloydbInstance_createInstanceWithMandatoryFields
• TestAccAlloydbInstance_createPrimaryAndReadPoolInstance
• TestAccAlloydbInstance_networkConfig
• TestAccAlloydbInstance_secondaryInstanceMaximumFields
• TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag
• TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig
• TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig
• TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance
• TestAccAlloydbInstance_update
• TestAccAlloydbUser_alloydbUserBuiltinTestExample
• TestAccAlloydbUser_alloydbUserIamTestExample
• TestAccAlloydbUser_updatePassword_BuiltIn
• TestAccAlloydbUser_updateRoles_BuiltIn
• TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicTestExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_continuousBackup_enabledByDefault[Debug log]
TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved[Debug log]
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_missingWeeklySchedule[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_usingCMEK[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_networkConfig[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Error message] [Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Error message] [Debug log]
TestAccAlloydbUser_updateRoles_IAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 344 insertions(+), 171 deletions(-))
google-beta provider: Diff ( 16 files changed, 344 insertions(+), 171 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 7 files changed, 24 insertions(+), 11 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field network within resource google_alloydb_cluster was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 67
Passed tests: 55
Skipped tests: 4
Affected tests: 8

Click here to see the affected service packages

• alloydb

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample
• TestAccAlloydbInstance_secondaryInstanceMaximumFields
• TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag
• TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig
• TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig
• TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance
• TestAccAlloydbUser_updatePassword_BuiltIn
• TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 347 insertions(+), 172 deletions(-))
google-beta provider: Diff ( 16 files changed, 347 insertions(+), 172 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 7 files changed, 27 insertions(+), 12 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field network within resource google_alloydb_cluster was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 67
Passed tests: 62
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

• alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test