Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main feature branch 6.0.0 - 8/21 #11513

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 21, 2024

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 282 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 12 files changed, 304 insertions(+), 76 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3902
Passed tests: 3483
Skipped tests: 403
Affected tests: 16

Click here to see the affected service packages

All service packages are affected

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_firestore
  • TestAccComputeDisk_storagePoolSpecified
  • TestAccComputeGlobalAddress_update
  • TestAccComputeInstance_bootDisk_storagePoolSpecified
  • TestAccComputeInstance_confidentialHyperDiskBootDisk
  • TestAccComputeNetworkFirewallPolicyRule_multipleRules
  • TestAccContainerClusterDatasource_regional
  • TestAccDataformRepository_updated
  • TestAccDataprocVirtualCluster_basic
  • TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update
  • TestAccKmsCryptoKey_keyAccessJustificationsPolicy
  • TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample
  • TestAccSecurityCenterFolderNotificationConfig_basic
  • TestAccSecurityCenterManagement
  • TestAccSecurityCenterV2FolderNotificationConfig_basic
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexBasicTwoExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeGlobalAddress_update[Debug log]
TestAccSecurityCenterManagement[Debug log]
TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexBasicTwoExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_firestore[Error message] [Debug log]
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_confidentialHyperDiskBootDisk[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerClusterDatasource_regional[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocVirtualCluster_basic[Error message] [Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update[Error message] [Debug log]
TestAccKmsCryptoKey_keyAccessJustificationsPolicy[Error message] [Debug log]
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample[Error message] [Debug log]
TestAccSecurityCenterFolderNotificationConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderNotificationConfig_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to commit merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants