Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6.0-related VCR failures and skip previously failing ones #11522

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 21, 2024

fixes hashicorp/terraform-provider-google#19209

Test failures sourced from #11513 (comment)

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 17 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 10 files changed, 19 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 17 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 11 files changed, 20 insertions(+), 2 deletions(-))

@wyardley
Copy link
Contributor

@c2thorn not sure if #11514 helps, but mentioning in case it comes up

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1397
Passed tests: 1272
Skipped tests: 119
Affected tests: 6

Click here to see the affected service packages
  • dataform
  • networksecurity
  • securitycenter
  • securitycenterv2
  • cloudfunctions
  • compute
  • container
  • dataproc
  • gkehub2
  • kms

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallPolicyRule_multipleRules
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccContainerClusterDatasource_regional
  • TestAccSecurityCenterV2FolderNotificationConfig_basic
  • TestAccDataformRepository_updated
  • TestAccSecurityCenterFolderNotificationConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1397
Passed tests: 1273
Skipped tests: 119
Affected tests: 5

Click here to see the affected service packages
  • compute
  • dataproc
  • networksecurity
  • securitycenter
  • kms
  • securitycenterv2
  • cloudfunctions
  • container
  • dataform
  • gkehub2

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallPolicyRule_multipleRules
  • TestAccSecurityCenterFolderNotificationConfig_basic
  • TestAccSecurityCenterV2FolderNotificationConfig_basic
  • TestAccContainerClusterDatasource_regional
  • TestAccDataformRepository_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccContainerClusterDatasource_regional[Debug log]
TestAccDataformRepository_updated[Debug log]
TestAccSecurityCenterFolderNotificationConfig_basic[Debug log]
TestAccSecurityCenterV2FolderNotificationConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerClusterDatasource_regional[Debug log]
TestAccDataformRepository_updated[Debug log]
TestAccSecurityCenterFolderNotificationConfig_basic[Debug log]
TestAccSecurityCenterV2FolderNotificationConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 19 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 12 files changed, 22 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1397
Passed tests: 1277
Skipped tests: 120
Affected tests: 0

Click here to see the affected service packages
  • securitycenter
  • securitycenterv2
  • cloudfunctions
  • gkehub2
  • kms
  • networksecurity
  • compute
  • container
  • dataform
  • dataproc

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): 6.0-related known test failures
4 participants