Fix 6.0-related VCR failures and skip previously failing ones (#11522)

GoogleCloudPlatform · Aug 22, 2024 · 01255de · 01255de
1 parent 4e92aad
commit 01255de
Show file tree

Hide file tree

Showing 12 changed files with 22 additions and 2 deletions.
diff --git a/mmv1/products/networksecurity/ServerTlsPolicy.yaml b/mmv1/products/networksecurity/ServerTlsPolicy.yaml
@@ -49,6 +49,7 @@ examples:
   - !ruby/object:Provider::Terraform::Examples
     min_version: beta
     name: 'network_security_server_tls_policy_basic'
+    skip_vcr: true
     primary_resource_id: 'default'
     vars:
       resource_name: 'my-server-tls-policy'

diff --git a/...hird_party/terraform/services/cloudfunctions/resource_cloudfunctions_function_test.go.erb b/...hird_party/terraform/services/cloudfunctions/resource_cloudfunctions_function_test.go.erb
@@ -332,6 +332,8 @@ func TestAccCloudFunctionsFunction_cmek(t *testing.T) {
 <% end -%>
 
 func TestAccCloudFunctionsFunction_firestore(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 	funcResourceName := "google_cloudfunctions_function.function"
 	functionName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))

diff --git a/mmv1/third_party/terraform/services/compute/resource_compute_disk_test.go.erb b/mmv1/third_party/terraform/services/compute/resource_compute_disk_test.go.erb
@@ -1615,6 +1615,8 @@ resource "google_compute_disk" "foobar" {
 }
 
 func TestAccComputeDisk_storagePoolSpecified(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	storagePoolName := fmt.Sprintf("tf-test-storage-pool-%s", acctest.RandString(t, 10))

diff --git a/mmv1/third_party/terraform/services/compute/resource_compute_instance_test.go.erb b/mmv1/third_party/terraform/services/compute/resource_compute_instance_test.go.erb
@@ -2041,6 +2041,8 @@ func TestAccComputeInstanceConfidentialInstanceConfigMain(t *testing.T) {
 }
 
 func TestAccComputeInstance_confidentialHyperDiskBootDisk(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 	kms := acctest.BootstrapKMSKeyWithPurposeInLocationAndName(t, "ENCRYPT_DECRYPT", "us-central1", "tf-bootstrap-hyperdisk-key1")
 
@@ -10201,6 +10203,8 @@ resource "google_compute_instance" "foobar" {
 }
 
 func TestAccComputeInstance_bootDisk_storagePoolSpecified(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	instanceName := fmt.Sprintf("tf-test-instance-%s", acctest.RandString(t, 10))

diff --git a/...arty/terraform/services/compute/resource_compute_network_firewall_policy_rule_test.go.erb b/...arty/terraform/services/compute/resource_compute_network_firewall_policy_rule_test.go.erb
@@ -67,6 +67,8 @@ func TestAccComputeNetworkFirewallPolicyRule_update(t *testing.T) {
 }
 
 func TestAccComputeNetworkFirewallPolicyRule_multipleRules(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
   t.Parallel()
 
   context := map[string]interface{}{

diff --git a/mmv1/third_party/terraform/services/container/data_source_google_container_cluster_test.go b/mmv1/third_party/terraform/services/container/data_source_google_container_cluster_test.go
@@ -60,7 +60,7 @@ func TestAccContainerClusterDatasource_regional(t *testing.T) {
 							"enable_tpu":                   {},
 							"pod_security_policy_config.#": {},
 							"deletion_protection":          {},
-							"resource_labels":              {},
+							"resource_labels.%":            {},
 						},
 					),
 				),

diff --git a/mmv1/third_party/terraform/services/dataform/resource_dataform_repository_test.go.erb b/mmv1/third_party/terraform/services/dataform/resource_dataform_repository_test.go.erb
@@ -95,7 +95,7 @@ resource "google_sourcerepo_repository" "git_repository" {
 
 resource "google_secret_manager_secret" "secret" {
   provider = google-beta
-  secret_id = "secret"
+  secret_id = "tf-test-secret%{random_suffix}"
 
   replication {
     auto {}

diff --git a/mmv1/third_party/terraform/services/dataproc/resource_dataproc_cluster_test.go.erb b/mmv1/third_party/terraform/services/dataproc/resource_dataproc_cluster_test.go.erb
@@ -106,6 +106,8 @@ func TestAccDataprocCluster_basic(t *testing.T) {
 }
 
 func TestAccDataprocVirtualCluster_basic(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	var cluster dataproc.Cluster

diff --git a/mmv1/third_party/terraform/services/gkehub2/resource_gke_hub_membership_binding_test.go b/mmv1/third_party/terraform/services/gkehub2/resource_gke_hub_membership_binding_test.go
@@ -10,6 +10,8 @@ import (
 )
 
 func TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update(t *testing.T) {
+	// Currently failing
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{

diff --git a/mmv1/third_party/terraform/services/kms/resource_kms_crypto_key_test.go.erb b/mmv1/third_party/terraform/services/kms/resource_kms_crypto_key_test.go.erb
@@ -822,6 +822,7 @@ resource "google_project" "acceptance" {
   project_id      = "%s"
   org_id          = "%s"
   billing_account = "%s"
+  deletion_policy = "DELETE"
 }
 
 resource "google_project_service" "acceptance" {

diff --git a/...d_party/terraform/services/securitycenter/resource_scc_folder_notification_config_test.go b/...d_party/terraform/services/securitycenter/resource_scc_folder_notification_config_test.go
@@ -64,6 +64,7 @@ func testAccSecurityCenterFolderNotificationConfig_basic(context map[string]inte
 resource "google_folder" "folder" {
   parent       = "organizations/%{org_id}"
   display_name = "tf-test-folder-name%{random_suffix}"
+  deletion_protection = false
 }
 
 resource "time_sleep" "wait_1_minute" {
@@ -97,6 +98,7 @@ func testAccSecurityCenterFolderNotificationConfig_update(context map[string]int
 resource "google_folder" "folder" {
   parent       = "organizations/%{org_id}"
   display_name = "tf-test-folder-name%{random_suffix}"
+  deletion_protection = false
 }
 
 resource "google_pubsub_topic" "scc_folder_notification_config" {

diff --git a/...ty/terraform/services/securitycenterv2/resource_scc_v2_folder_notification_config_test.go b/...ty/terraform/services/securitycenterv2/resource_scc_v2_folder_notification_config_test.go
@@ -64,6 +64,7 @@ func testAccSecurityCenterV2FolderNotificationConfig_basic(context map[string]in
 resource "google_folder" "folder" {
   parent       = "organizations/%{org_id}"
   display_name = "tf-test-folder-name%{random_suffix}"
+  deletion_protection = false
 }
 
 resource "time_sleep" "wait_1_minute" {
@@ -98,6 +99,7 @@ func testAccSecurityCenterV2FolderNotificationConfig_update(context map[string]i
 resource "google_folder" "folder" {
   parent       = "organizations/%{org_id}"
   display_name = "tf-test-folder-name%{random_suffix}"
+  deletion_protection = false
 }
 
 resource "google_pubsub_topic" "scc_v2_folder_notification_config" {