Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6.0-related VCR failures and skip previously failing ones #11522

Merged
merged 3 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/products/networksecurity/go_ServerTlsPolicy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ custom_code:
examples:
- name: 'network_security_server_tls_policy_basic'
primary_resource_id: 'default'
skip_vcr: true
min_version: 'beta'
vars:
resource_name: 'my-server-tls-policy'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,8 @@ func TestAccCloudFunctionsFunction_cmek(t *testing.T) {
<% end -%>

func TestAccCloudFunctionsFunction_firestore(t *testing.T) {
// Currently failing
acctest.SkipIfVcr(t)
t.Parallel()
funcResourceName := "google_cloudfunctions_function.function"
functionName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1615,6 +1615,8 @@ resource "google_compute_disk" "foobar" {
}

func TestAccComputeDisk_storagePoolSpecified(t *testing.T) {
// Currently failing
acctest.SkipIfVcr(t)
t.Parallel()

storagePoolName := fmt.Sprintf("tf-test-storage-pool-%s", acctest.RandString(t, 10))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2041,6 +2041,8 @@ func TestAccComputeInstanceConfidentialInstanceConfigMain(t *testing.T) {
}

func TestAccComputeInstance_confidentialHyperDiskBootDisk(t *testing.T) {
// Currently failing
acctest.SkipIfVcr(t)
t.Parallel()
kms := acctest.BootstrapKMSKeyWithPurposeInLocationAndName(t, "ENCRYPT_DECRYPT", "us-central1", "tf-bootstrap-hyperdisk-key1")

Expand Down Expand Up @@ -10201,6 +10203,8 @@ resource "google_compute_instance" "foobar" {
}

func TestAccComputeInstance_bootDisk_storagePoolSpecified(t *testing.T) {
// Currently failing
acctest.SkipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-instance-%s", acctest.RandString(t, 10))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func TestAccContainerClusterDatasource_regional(t *testing.T) {
"enable_tpu": {},
"pod_security_policy_config.#": {},
"deletion_protection": {},
"resource_labels": {},
"resource_labels.%": {},
},
),
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ resource "google_sourcerepo_repository" "git_repository" {

resource "google_secret_manager_secret" "secret" {
provider = google-beta
secret_id = "secret"
secret_id = "tf-test-secret%{random_suffix}"

replication {
auto {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ func TestAccDataprocCluster_basic(t *testing.T) {
}

func TestAccDataprocVirtualCluster_basic(t *testing.T) {
// Currently failing
acctest.SkipIfVcr(t)
t.Parallel()

var cluster dataproc.Cluster
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
)

func TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update(t *testing.T) {
// Currently failing
acctest.SkipIfVcr(t)
t.Parallel()

context := map[string]interface{}{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,7 @@ resource "google_project" "acceptance" {
project_id = "%s"
org_id = "%s"
billing_account = "%s"
deletion_policy = "DELETE"
}

resource "google_project_service" "acceptance" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func testAccSecurityCenterFolderNotificationConfig_basic(context map[string]inte
resource "google_folder" "folder" {
parent = "organizations/%{org_id}"
display_name = "tf-test-folder-name%{random_suffix}"
deletion_protection = false
}

resource "time_sleep" "wait_1_minute" {
Expand Down Expand Up @@ -97,6 +98,7 @@ func testAccSecurityCenterFolderNotificationConfig_update(context map[string]int
resource "google_folder" "folder" {
parent = "organizations/%{org_id}"
display_name = "tf-test-folder-name%{random_suffix}"
deletion_protection = false
}

resource "google_pubsub_topic" "scc_folder_notification_config" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func testAccSecurityCenterV2FolderNotificationConfig_basic(context map[string]in
resource "google_folder" "folder" {
parent = "organizations/%{org_id}"
display_name = "tf-test-folder-name%{random_suffix}"
deletion_protection = false
}

resource "time_sleep" "wait_1_minute" {
Expand Down Expand Up @@ -98,6 +99,7 @@ func testAccSecurityCenterV2FolderNotificationConfig_update(context map[string]i
resource "google_folder" "folder" {
parent = "organizations/%{org_id}"
display_name = "tf-test-folder-name%{random_suffix}"
deletion_protection = false
}

resource "google_pubsub_topic" "scc_v2_folder_notification_config" {
Expand Down
Loading