Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Undelete for Vmwareengine Private Cloud #11480

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

swamitagupta
Copy link
Member

@swamitagupta swamitagupta commented Aug 18, 2024

Support undelete of the Private Cloud if it exists in the 'marked for deletion' state.

Private Cloud Acceptance Tests pass at gpaste/4841587882590208

Release Note Template for Downstream PRs (will be copied)

vmwareengine: Added PC undelete support in `google_vmwareengine_private_cloud`

@github-actions github-actions bot requested a review from ScottSuarez August 18, 2024 06:06
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 116 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 2 files changed, 116 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • vmwareengine

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@ScottSuarez ScottSuarez merged commit c52857e into GoogleCloudPlatform:main Aug 20, 2024
15 checks passed
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
c2thorn added a commit to c2thorn/magic-modules that referenced this pull request Aug 21, 2024
…n-FEATURE-BRANCH-6.0.0

* commit 'bc5def9f8136003836911e78567dc8849a39be6d':
  Fix test `TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule` (GoogleCloudPlatform#11469)
  Promoted labelFingerprint field to GA (GoogleCloudPlatform#11504)
  Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#11485)
  Support Undelete for Vmwareengine Private Cloud (GoogleCloudPlatform#11480)
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants