Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi_region_auxiliary from google_bigquery_reservation #11304

Conversation

obada-ab
Copy link
Contributor

@obada-ab obada-ab commented Jul 31, 2024

Remove multi_region_auxiliary from google_bigquery_reservation as this field is no longer supported

b/350571636

Release Note Template for Downstream PRs (will be copied)

bigqueryreservation: removed `multi_region_auxiliary` from `google_bigquery_reservation`

@github-actions github-actions bot requested a review from hao-nan-li July 31, 2024 10:07
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 6 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 41 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field multi_region_auxiliary within resource google_bigquery_reservation was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician modular-magician requested a review from wj-chen July 31, 2024 10:18
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryreservation

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Member

@wj-chen wj-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"removed" in the release notes.

@hao-nan-li hao-nan-li added the override-breaking-change Allows a potential breaking change to be merged label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/bigquery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants