Remove resource google_identity_platform_project_default_config

[hao-nan-li]

fixes hashicorp/terraform-provider-google#15963

Release Note Template for Downstream PRs (will be copied)

identityplatform: removed resource `google_identity_platform_project_default_config` in favor of `google_identity_platform_project_config`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2 insertions(+), 1155 deletions(-))
google-beta provider: Diff ( 4 files changed, 2 insertions(+), 1155 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 281 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_identity_platform_project_default_config was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• identityplatform

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[hao-nan-li]

Not sure why the lint is failing, the error message actually indicates the file is removed, which is intended.

[c2thorn]

can you add an upgrade guide entry here too. Looks like we had a removal section last year: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown#removals

[c2thorn]

We are specifically removing this in favor of google_identity_platform_project_config, can we add that to the release note and upgrade guide

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 8 insertions(+), 1155 deletions(-))
google-beta provider: Diff ( 5 files changed, 8 insertions(+), 1155 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 281 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_identity_platform_project_default_config was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• identityplatform

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[c2thorn]

applying minor tweak, will give LGTM after build

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 8 insertions(+), 1155 deletions(-))
google-beta provider: Diff ( 5 files changed, 8 insertions(+), 1155 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 281 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_identity_platform_project_default_config was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• identityplatform

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log