fix: Allow Pub/Sub Topic update to remove schema settings

[kamalaboulhosn]

Remove default_from_api from Pub/Sub Topic schemaSettings so that schema settings can be removed from a topic. Fixes hashicorp/terraform-provider-google#15925.

Release Note Template for Downstream PRs (will be copied)

pubsub: Allow `schema_settings` of `google_pubsub_topic` to be removed

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 2 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field schema_settings transitioned from optional+computed to optional google_pubsub_topic - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 49
Passed tests: 47
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• pubsub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPubsubTopic_schema

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPubsubTopic_schema[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

LGTM, but I think we might still want an entry in the upgrade guide for this. Something like "a default value is not longer provided for schema_settings, instead an empty value means the setting should be cleared"?

[kamalaboulhosn]

@roaks3 Added an entry as suggested.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 18 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 18 insertions(+), 2 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field schema_settings transitioned from optional+computed to optional google_pubsub_topic - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 49
Passed tests: 48
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log