Sync main feature branch 6.0.0 - 7/16 #11179
Conversation
…loudPlatform#11094) Co-authored-by: Nick Elliot <[email protected]>
…lingNoLimitConfigExample` beta-only (GoogleCloudPlatform#11111)
Co-authored-by: Sam Levenick <[email protected]>
…re write modes (GoogleCloudPlatform#11116) Co-authored-by: Thomas Rodgers <[email protected]>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_instance" "primary" {
observability_config {
enabled = # value needed
max_query_string_length = # value needed
preserve_comments = # value needed
query_plans_per_minute = # value needed
record_application_tags = # value needed
track_active_queries = # value needed
track_wait_event_types = # value needed
track_wait_events = # value needed
}
}
Resource: resource "google_cloudfunctions_function" "primary" {
build_service_account = # value needed
}
Resource: resource "google_network_connectivity_hub" "primary" {
routing_vpcs {
uri = # value needed
}
}
|
Tests analyticsTotal tests: 3860 Click here to see the affected service packages
Tests were added that are skipped in VCR:
Tests were added that are GA-only additions and require manual runs:
Action takenFound 52 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_instance" "primary" {
observability_config {
enabled = # value needed
max_query_string_length = # value needed
preserve_comments = # value needed
query_plans_per_minute = # value needed
record_application_tags = # value needed
track_active_queries = # value needed
track_wait_event_types = # value needed
track_wait_events = # value needed
}
}
Resource: resource "google_cloudfunctions_function" "primary" {
build_service_account = # value needed
}
Resource: resource "google_network_connectivity_hub" "primary" {
routing_vpcs {
uri = # value needed
}
}
|
Tests analyticsTotal tests: 3860 Click here to see the affected service packages
Tests were added that are skipped in VCR:
Tests were added that are GA-only additions and require manual runs:
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
these tests are already failing on main @shuyama1 |
|
Do we know what breaking change #11179 (comment) is pointing to? We shouldn't be expecting any breaking changes, since these are changes merged into the main. However, it may be due to DCL migrations where changing in project is an known false(?) alert. |
Yes it is from the DCL change: #11052 |
c2thorn
added
the
override-breaking-change
Cool, thanks for confirming! |
c2thorn
merged commit 4b86cb2
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0
Release Note Template for Downstream PRs (will be copied)