workbench instances support for static external IP

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

workbench: added `access_configs` to `google_workbench_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[shuyama1]

Are you able to get the tests pass locally? The tests failed due to The zone 'projects/xxxx/zones/us-central1-a' does not have enough resources available to fulfill the request, but it's not clear which resource is hitting the quota limit.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[shuyama1]

still waiting on rollout to complete

[github-actions]

@bcreddy-gcp, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[shuyama1]

@bcreddy-gcp is the rollout finished? Also please let me know if you need help debug the test failure. Thanks

[bcreddy-gcp]

Rollout is finished. Let me rerun the tests.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[shuyama1]

Thank you!